Allow dynamic attributes for template tags

compiler/TemplateCompiler.js

@@ -100,10 +100,10 @@ TemplateCompiler.prototype = {
         var rootNode;
         var templateBuilder;
         function handleErrors() {
-            var message = 'An error occurred while trying to compile template at path "' + filePath + '". Error(s) in template: ';
+            var message = 'An error occurred while trying to compile template at path "' + filePath + '". Error(s) in template:\n';
             var errors = _this.getErrors();
             for (var i = 0, len = errors.length; i < len; i++) {
-                message += + '(' + (i + 1) + ') ' + (errors[i].pos ? '[' + errors[i].pos + '] ' : '') + errors[i].message + ' ';
+                message += (i + 1) + ') ' + (errors[i].pos ? '[' + errors[i].pos + '] ' : '') + errors[i].message + '\n';
             }
             var error = new Error(message);
             error.errors = _this.getErrors();

compiler/taglibs/taglib-loader.js

@@ -67,8 +67,7 @@ function handleAttributes(value, parent, path) {
             attrProps = {
                 type: 'string'
             };
-        }
-        else if (typeof attrProps === 'string') {
+        } else if (typeof attrProps === 'string') {
             attrProps = {
                 type: attrProps
             };
@@ -88,6 +87,13 @@ function buildTag(tagObject, path, taglib, dirname) {
 
     var tag = new Taglib.Tag(taglib);
 
+    if (tagObject.attributes == null) {
+        // allow any attributes if no attributes are declared
+        tagObject.attributes = {
+            '*': 'string'
+        };
+    }
+
     propertyHandlers(tagObject, {
         name: function(value) {
             tag.name = value;

taglibs/core/core-tag-transformer.js

@@ -416,8 +416,12 @@ module.exports = function transform(node, compiler, template) {
                     if (attrDef.removeDashes === true) {
                         name = removeDashes(name);
                     }
-                    node.addDynamicAttribute(name, value);
-                    node.setDynamicAttributesProperty(attrDef.targetProperty);
+                    if (node.addDynamicAttribute) {
+                        node.addDynamicAttribute(name, value);
+                        node.setDynamicAttributesProperty(attrDef.targetProperty);    
+                    } else {
+                        node.setProperty(name, value);    
+                    }
                 } else {
                     node.setProperty(name, value);
                 }

test/render-rhtml-tests.js

@@ -392,4 +392,9 @@ describe('raptor-templates/rhtml' , function() {
     it("should support scanning a directory for tags", function(done) {
         testRender("test-project/rhtml-templates/scanned-tags.rhtml", {}, done);
     });
+
+    it("should support scanning a directory for tags", function(done) {
+        testRender("test-project/rhtml-templates/template-tag-dynamic-attributes.rhtml", {}, done);
+    });
+
 });

test/test-project/raptor-taglib.json

@@ -80,6 +80,9 @@
                     "default-value": 100
                 }
             }
+        },
+        "test-template-tag-dynamic-attributes": {
+            "template": "./hello.rhtml"
         }
     },
     "tags-dir": "./scanned-tags"

test/test-project/rhtml-templates/template-tag-dynamic-attributes.rhtml

@@ -0,0 +1 @@
+<test-template-tag-dynamic-attributes name="Frank"/>

test/test-project/rhtml-templates/template-tag-dynamic-attributes.rhtml.expected.html

@@ -0,0 +1 @@
+Hello Frank!