From eceab5a444c5ab50b1cddac02c41cf2cd13c8e8f Mon Sep 17 00:00:00 2001 From: Phil Gates-Idem Date: Thu, 31 Jul 2014 16:15:55 -0400 Subject: [PATCH] Fixing buggy loop conditions (index variable out of range) --- lib/Widget.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/Widget.js b/lib/Widget.js index 2aa4d87e4..7268634dd 100644 --- a/lib/Widget.js +++ b/lib/Widget.js @@ -133,7 +133,7 @@ EventEmitterWrapper.prototype = { return event === curEvent; }); } else { - for (var i=listeners.length; i>=0; i--) { + for (var i = listeners.length - 1; i >= 0; i--) { var cur = listeners[i]; target.removeListener(cur[INDEX_EVENT], cur[INDEX_LISTENER]); } @@ -149,7 +149,7 @@ EventEmitterWrapper.prototype.addListener = EventEmitterWrapper.prototype.on; function attachDestroy(target, subscribeToList) { target.once('destroy', function() { - for (var i=subscribeToList.length; i >= 0; i--) { + for (var i = subscribeToList.length - 1; i >= 0; i--) { if (subscribeToList[i]._target === target) { subscribeToList.splice(i, 1); break; @@ -189,7 +189,7 @@ SubscriptionTracker.prototype = { unsubscribeAll: function() { var subscribeToList = this._subscribeToList; - for (var i=subscribeToList.length; i>=0; i--) { + for (var i = subscribeToList.length - 1; i >= 0; i--) { subscribeToList[i].removeAllListeners(); } subscribeToList.length = 0;