Fixing bug that occurs when string concatenation is being used and one of the parts is a ternary operator expression. Each part needs to be surrounded with parentheses.

compiler/TemplateBuilder.js

@@ -82,7 +82,7 @@ CodeWriter.prototype = {
         this._code.append(this._indent + '__helpers.' + methodName + '(context');
 
         if (args.length) {
-            this._code.append(', ');    
+            this._code.append(', ');
         }
 
         writeArgs(this, args);
@@ -162,7 +162,12 @@ CodeWriter.prototype = {
                     code.append(' +\n' + this.indentStr());
                 }
 
+                // The expression might be a ternary operator
+                // so we need to surround it with parentheses.
+                // Minification will remove unnecessary parentheses.
+                code.append('(');
                 writeArg(_this, expression);
+                code.append(')');
 
                 if (i !== 0) {
                     _this.decIndent();
@@ -203,7 +208,7 @@ CodeWriter.prototype = {
             this.firstStatement = false;
             this._bufferedWrites = null;
             if (this.concatWrites) {
-                concat();    
+                concat();
             } else {
                 chain();
             }

test-render-rxml.sh

@@ -0,0 +1 @@
+node_modules/.bin/mocha --ui bdd --reporter spec ./test/render-rxml-tests.js

test/render-rxml-tests.js

@@ -206,7 +206,7 @@ describe('raptor-templates/rxml' , function() {
         testRender("test-project/rxml-templates/include.rxml", {}, done);
     });
     
-    it("should allow for <c:invoke function... />", function(done) {        
+    it("should allow for <c:invoke function... />", function(done) {
         testRender("test-project/rxml-templates/invoke.rxml", {}, done);
     });
     
@@ -362,5 +362,9 @@ describe('raptor-templates/rxml' , function() {
         testRender("test-project/rxml-templates/layout-use.rxml", {}, done);
     });
 
+    it("should add parentheses around each expression when using string concatenation to handle ternary operator", function(done) {
+        testRender("test-project/rxml-templates/string-concat-with-ternary-operator.rxml", {}, done);
+    });
+
 });
 

test/test-project/rhtml-templates/simple.rhtml.js

@@ -12,26 +12,26 @@ module.exports = function create(__helpers) {
 
     var message=data.message;
 
-    context.w('<div class="hello-world ' +
+    context.w(('<div class="hello-world ') +
-      escapeXmlAttr(rootClass) +
+      (escapeXmlAttr(rootClass)) +
-      '">' +
+      ('">') +
-      escapeXml(message) +
+      (escapeXml(message)) +
-      '</div>');
+      ('</div>'));
 
     if (notEmpty(colors)) {
-      context.w('<ul>');
+      context.w(('<ul>'));
 
       forEach(colors, function(color) {
-        context.w('<li class="color">' +
+        context.w(('<li class="color">') +
-          escapeXml(color) +
+          (escapeXml(color)) +
-          '</li>');
+          ('</li>'));
       });
 
-      context.w('</ul>');
+      context.w(('</ul>'));
     }
 
     if (empty(colors)) {
-      context.w('<div>No colors!</div>');
+      context.w(('<div>No colors!</div>'));
     }
   };
 }

test/test-project/rxml-templates/simple.rxml.js

@@ -17,26 +17,26 @@ module.exports = function create(__helpers) {
         "name": "World"
       });
 
-    context.w('<div class="hello-world ' +
+    context.w(('<div class="hello-world ') +
-      escapeXmlAttr(rootClass) +
+      (escapeXmlAttr(rootClass)) +
-      '">' +
+      ('">') +
-      escapeXml(message) +
+      (escapeXml(message)) +
-      '</div>');
+      ('</div>'));
 
     if (notEmpty(colors)) {
-      context.w('<ul>');
+      context.w(('<ul>'));
 
       forEach(colors, function(color) {
-        context.w('<li class="color">' +
+        context.w(('<li class="color">') +
-          escapeXml(color) +
+          (escapeXml(color)) +
-          '</li>');
+          ('</li>'));
       });
 
-      context.w('</ul>');
+      context.w(('</ul>'));
     }
 
     if (empty(colors)) {
-      context.w('<div>No colors!</div>');
+      context.w(('<div>No colors!</div>'));
     }
   };
 }

test/test-project/rxml-templates/string-concat-with-ternary-operator.rxml

@@ -0,0 +1,4 @@
+<c-template c-whitespace="preserve">
+A: $!{true ? 'ABC' : ''}
+B: This should be outputted as well.
+</c-template>

test/test-project/rxml-templates/string-concat-with-ternary-operator.rxml.expected.html

@@ -0,0 +1,3 @@
+
+A: ABC
+B: This should be outputted as well.

test/test-project/rxml-templates/string-concat-with-ternary-operator.rxml.expected.js

@@ -0,0 +1,10 @@
+module.exports = function create(__helpers) {
+  var empty = __helpers.e,
+      notEmpty = __helpers.ne;
+
+  return function render(data, context) {
+    context.w(('\nA: ') +
+      (true ? 'ABC' : '') +
+      ('\nB: This should be outputted as well.\n'));
+  };
+}

test/test-project/simple.rhtml.expected.js

@@ -3,6 +3,6 @@ module.exports = function create(__helpers) {
       notEmpty = __helpers.ne;
 
   return function render(data, context) {
-    context.w('Hello John');
+    context.w(('Hello John'));
   };
 }