archive-gh-me/marko
1
0
Fork 0
mirror of https://github.com/marko-js/marko.git synced 2025-12-08 19:26:05 +00:00
Code Issues Projects Releases Wiki Activity

Marko v3: Improved handling of invalid attributes

Browse Source
This commit is contained in:
Patrick Steele-Idem 2016-02-11 10:24:41 -07:00
parent fcd2cad02c
commit c78ca5f352
2 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
compiler/CompileContext.js
View File

@ -267,6 +267,10 @@ class CompileContext {
let attrDef = taglibLookup.getAttribute(tagName, attrName);
if (!attrDef) {
if (tagDef) {
if (node.removeAttribute) {
node.removeAttribute(attrName);
}
// var isAttrForTaglib = compiler.taglibs.isTaglib(attrUri);
//Tag doesn't allow dynamic attributes
this.addError({

1
compiler/ast/CustomTag.js
View File

@ -131,6 +131,7 @@ function buildInputProps(el, context) {
var attrDef = attr.def || context.taglibLookup.getAttribute(el.tagName, attr.name);
if (!attrDef) {
context.addError(el, 'Unsupported attribute of "' + attrName + '" found on the <' + el.tagName + '> custom tag.');
return; // Skip over attributes that are not supported
}