archive-gh-me/marko
1
0
Fork 0
mirror of https://github.com/marko-js/marko.git synced 2025-12-08 19:26:05 +00:00
Code Issues Projects Releases Wiki Activity

Reject class with extends for single file UI components

Browse Source
This commit is contained in:
Patrick Steele-Idem 2017-02-08 22:53:46 -08:00
parent ab1e53701b
commit baf6cf6a14
4 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

0
test/autotests/render/error-component-class-extends/expected.html Normal file
View File

6
test/autotests/render/error-component-class-extends/template.marko Normal file
View File

@ -0,0 +1,6 @@
class Foo extends Bar {
}
<div>
</div>

6
test/autotests/render/error-component-class-extends/test.js Normal file
View File

@ -0,0 +1,6 @@
var expect = require('chai').expect;
exports.checkError = function(e) {
expect(e.toString()).to.contain('A component class is not allowed to use `extends`');
expect(e.toString()).to.contain('https://github.com/marko-js/marko/wiki/Error:-Component-class-with-extends');
};

6
widgets/taglib/TransformHelper/handleRootNodes.js
View File

@ -207,6 +207,12 @@ function handleClassDeclaration(classEl, transformHelper) {
return; return;
} }
let expression = tree.body[0].expression; let expression = tree.body[0].expression;
if (expression.superClass && expression.superClass.name) {
transformHelper.context.addError(classEl, 'A component class is not allowed to use `extends`. See: https://github.com/marko-js/marko/wiki/Error:-Component-class-with-extends');
return;
}
let object = classToObject(expression); let object = classToObject(expression);
let componentVar = transformHelper.context.addStaticVar('marko_component', escodegen.generate(object)); let componentVar = transformHelper.context.addStaticVar('marko_component', escodegen.generate(object));