archive-gh-me/marko
1
0
Fork 0
mirror of https://github.com/marko-js/marko.git synced 2025-12-08 19:26:05 +00:00
Code Issues Projects Releases Wiki Activity

Forward error events from nested out of order async outs (#1275)

Browse Source 
* Forward error events from nested out of order async outs
This commit is contained in:
Dylan Piercey 2019-03-05 14:52:06 -08:00 committed by GitHub
parent e5f5149b58
commit a85230075f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 33 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/runtime/html/AsyncStream.js
View File

@ -466,7 +466,10 @@ var proto = (AsyncStream.prototype = {
},
createOut: function() {
return new AsyncStream(this.global);
var newOut = new AsyncStream(this.global);
// Forward error events to the parent out.
newOut.on("error", this.emit.bind(this, "error"));
return newOut;
},
element: function(tagName, elementAttrs, openTagOnly) {

5
test/api/fixtures/render-await-client-reorder-unhandled-rejected-promise/template.marko Normal file
View File

@ -0,0 +1,5 @@
<div>
<await(input.userPromise) client-reorder>
<@then|user|>Hello ${user.name}!</@then>
</await>
</div>

24
test/api/fixtures/render-await-client-reorder-unhandled-rejected-promise/test.js Normal file
View File

@ -0,0 +1,24 @@
var nodePath = require("path");
exports.check = function(marko, markoCompiler, expect, snapshot, done) {
var template = marko.load(nodePath.join(__dirname, "template.marko"));
var out = template.createOut();
template.render(
{
userPromise: new Promise((_, reject) => {
setTimeout(function() {
reject(new Error("User Promise Rejected Error"));
}, 10);
})
},
out
);
out.on("error", err => {
expect(
err.message.indexOf("User Promise Rejected Error") !== -1
).to.equal(true);
done();
});
};