From a751d9ebb2ea6c80f1b04b109d9aa791e92ea91c Mon Sep 17 00:00:00 2001
From: Michael Rawlings <mirawlings@ebay.com>
Date: Tue, 11 May 2021 10:10:53 -0700
Subject: [PATCH] fix: update types

---
 .sizes.json                              |  6 +++---
 packages/runtime/src/dom/control-flow.ts | 15 +++++++++++----
 2 files changed, 14 insertions(+), 7 deletions(-)

diff --git a/.sizes.json b/.sizes.json
index caf17414e..d5f1bd4ff 100644
--- a/.sizes.json
+++ b/.sizes.json
@@ -6,9 +6,9 @@
     {
       "name": "*",
       "individual": {
-        "min": 8609,
-        "gzip": 3735,
-        "brotli": 3459
+        "min": 8662,
+        "gzip": 3765,
+        "brotli": 3469
       }
     }
   ]
diff --git a/packages/runtime/src/dom/control-flow.ts b/packages/runtime/src/dom/control-flow.ts
index 8bd08fb64..a075bda5e 100644
--- a/packages/runtime/src/dom/control-flow.ts
+++ b/packages/runtime/src/dom/control-flow.ts
@@ -4,9 +4,16 @@ import { Renderer, initRenderer } from "./renderer";
 import { Scope, createScope, getEmptyScope, set } from "./scope";
 import { NodeType } from "./dom";
 
-export type Conditional = {
-  scope?: Scope;
-  renderer?: Renderer;
+export type Conditional = (
+  | {
+      scope: Scope;
+      renderer: Renderer;
+    }
+  | {
+      scope: undefined;
+      renderer: undefined;
+    }
+) & {
   ___parentScopeOrScopes?: Scope | Array<Scope | number>;
   ___parentOffset?: number;
   ___referenceNode: Comment | Element;
@@ -129,7 +136,7 @@ export type Loop = {
 export function loop(
   referenceNode: Comment | Element,
   renderer: Renderer,
-  keyFn: (item: unknown) => string,
+  keyFn: (item: unknown) => unknown,
   parentScopeOrScopes?: Scope | Array<Scope | number>,
   parentOffset?: number
 ): Loop {