archive-gh-me/marko
1
0
Fork 0
mirror of https://github.com/marko-js/marko.git synced 2026-02-01 16:07:13 +00:00
Code Issues Projects Releases Wiki Activity

fix: ensure only child optimization ignores comments (#3012)

Browse Source 
* fix: ensure only child optimization ignores comments

* chore: add changeset
This commit is contained in:
Luke LaValva 2025-12-17 12:53:31 -08:00 committed by GitHub
parent 9b26913239
commit 7ec9683b16
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
4 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
.changeset/clever-chicken-drum.md Normal file
View File

@ -0,0 +1,5 @@
---
"@marko/runtime-tags": patch
---
Ignore comments for only child conditional optimization

2
packages/runtime-tags/src/__tests__/fixtures/toggle-only-child/__snapshots__/html.expected/template.js
View File

@ -9,7 +9,7 @@ export default _._template("__tests__/template.marko", input => {
_._html(`<span>${_._escape(value)}${_._el_resume($scope1_id, "#text/0")}</span>`);
_._scope($scope1_id, {
_: _._scope_with_id($scope0_id)
}, "__tests__/template.marko", "3:4");
}, "__tests__/template.marko", "4:4");
return 0;
}
}, $scope0_id, "#div/0", 1, /* value */1, /* value */1, "</div>", 1);

1
packages/runtime-tags/src/__tests__/fixtures/toggle-only-child/template.marko
View File

@ -1,5 +1,6 @@
<let/value=input.value>
<div>
// This comment shouldn't count as a child!
<if=value>
<span>${value}</span>
</if>

4
packages/runtime-tags/src/translator/util/is-only-child-in-parent.ts
View File

@ -29,7 +29,9 @@ export function getOnlyChildParentTagName(
parentTag &&
getTagDef(parentTag)?.html &&
parentTag.node.name.type === "StringLiteral" &&
(tag.parent as t.MarkoTagBody).body.length === branchSize
(tag.parent as t.MarkoTagBody).body.filter(
(node) => node.type !== "MarkoComment",
).length === branchSize
? parentTag.node.name.value
: false);
}