Fixes #695 - Default to ignoring unrecognized tags for XML files.

.gitignore

@@ -12,6 +12,7 @@ coverage
 ~*
 /.cache
 *.marko.js
+*.marko.xml.js
 /test/generated/
 .nyc_output
 yarn.lock

bin/markoc.js

@@ -46,6 +46,10 @@ function relPath(path) {
     }
 }
 
+function shouldIgnoreUnrecognizedTags(path) {
+    return path.endsWith('.xml') || path.endsWith('.xml.marko');
+}
+
 var args = require('argly').createParser({
         '--help': {
             type: 'boolean',
@@ -293,8 +297,6 @@ if (args.clean) {
                         console.log('Deleted: ' + file);
                         context.endAsync();
                     });
-
-
                 }
             }
         },
@@ -318,11 +320,18 @@ if (args.clean) {
             return;
         }
 
-        found[path] = true;
+        if (shouldIgnoreUnrecognizedTags(path)) {
+            compileOptions = compileOptions || {};
+            compileOptions.ignoreUnrecognizedTags = true;
+        }
 
+        found[path] = true;
         var outPath = path + '.js';
+
         console.log('Compiling:\n  Input:  ' + relPath(path) + '\n  Output: ' + relPath(outPath) + '\n');
+
         context.beginAsync();
+
         markoCompiler.compileFile(path, compileOptions, function(err, src) {
             if (err) {
                 failed.push('Failed to compile "' + relPath(path) + '". Error: ' + (err.stack || err));

compiler/CompileContext.js

@@ -110,6 +110,7 @@ class CompileContext extends EventEmitter {
         this.compilerType = this.options.compilerType || 'marko';
         this.compilerVersion = this.options.compilerVersion || markoPkgVersion;
         this.writeVersionComment = writeVersionComment !== 'undefined' ? writeVersionComment : true;
+        this.ignoreUnrecognizedTags = this.options.ignoreUnrecognizedTags || false;
 
         this._vars = {};
         this._uniqueVars = new UniqueVars();
@@ -421,9 +422,10 @@ class CompileContext extends EventEmitter {
             if (typeof tagName === 'string') {
                 tagDef = taglibLookup.getTag(tagName);
                 if (!tagDef &&
-                        !this.isMacro(tagName) &&
-                        tagName.indexOf(':') === -1 &&
-                        !htmlElements.isRegisteredElement(tagName, this.dirname)) {
+                    !this.isMacro(tagName) &&
+                    tagName.indexOf(':') === -1 &&
+                    !htmlElements.isRegisteredElement(tagName, this.dirname) &&
+                    !this.ignoreUnrecognizedTags) {
 
                     if (this._parsingFinished) {
                         this.addErrorUnrecognizedTag(tagName, elNode);

compiler/Compiler.js

@@ -138,7 +138,7 @@ class Compiler {
         var ast = this.parser.parse(src, context);
         context._parsingFinished = true;
 
-        if (context.unrecognizedTags) {
+        if (!context.ignoreUnrecognizedTags && context.unrecognizedTags) {
             for(let i=0; i<context.unrecognizedTags.length; i++) {
                 let unrecognizedTag = context.unrecognizedTags[i];
                 // See if the tag is a macro
@@ -167,4 +167,4 @@ class Compiler {
     }
 }
 
-module.exports = Compiler;
+module.exports = Compiler;

compiler/config.js

@@ -43,7 +43,13 @@ if (g.__MARKO_CONFIG) {
          * Whether the version should be written to the template as a comment e.g.
          * // Compiled using marko@4.0.0 - DO NOT EDIT
          */
-        writeVersionComment: true
+        writeVersionComment: true,
+
+        /**
+         * Whether unrecognized tags should be ignored or not. This flag will
+         * be enabled by default when compiling XML.
+         */
+        ignoreUnrecognizedTags: false
     };
 }
 

test/autotests/api-compiler/configure/test.js

@@ -4,6 +4,7 @@ exports.check = function(marko, markoCompiler, expect, helpers, done) {
     expect(compiler.config.writeToDisk).to.equal(true);
     expect(compiler.config.preserveWhitespace).to.equal(false);
     expect(compiler.config.writeVersionComment).to.equal(true);
+    expect(compiler.config.ignoreUnrecognizedTags).to.equal(false);
 
     compiler.configure({
         preserveWhitespace: true

test/autotests/markoc/single-xml-template/template.marko.xml

@@ -0,0 +1 @@
+<urlset></urlset>

test/autotests/markoc/single-xml-template/test.js

@@ -0,0 +1,8 @@
+var expect = require('chai').expect;
+
+exports.test = function(helpers) {
+    expect(helpers.existsSync('template.marko.xml.js')).to.equal(false);
+    var result = helpers.spawnSync(['template.marko.xml']);
+    expect(helpers.existsSync('template.marko.xml.js')).to.equal(true);
+    expect(result.status).to.equal(0);
+};

test/autotests/render/ignore-unrecognized-tag/expected.html

@@ -0,0 +1 @@
+<unrecognized></unrecognized>

test/autotests/render/ignore-unrecognized-tag/template.marko

@@ -0,0 +1 @@
+<unrecognized></unrecognized>

test/autotests/render/ignore-unrecognized-tag/test.js

@@ -0,0 +1,4 @@
+var expect = require('chai').expect;
+
+exports.templateData = {};
+exports.ignoreUnrecognizedTags = true;

test/util/runRenderTest.js

@@ -101,6 +101,10 @@ module.exports = function runRenderTest(dir, helpers, done, options) {
         require('marko/compiler').defaultOptions.preserveWhitespace = true;
     }
 
+    if (main.ignoreUnrecognizedTags) {
+        require('marko/compiler').defaultOptions.ignoreUnrecognizedTags = true;
+    }
+
     var oldDone = done;
     done = function(err) {
         require('marko/compiler').configure();
@@ -225,4 +229,4 @@ module.exports = function runRenderTest(dir, helpers, done, options) {
             delete require('marko/compiler').defaultOptions.preserveWhitespace;
         }
     }
-};
+};