From 489321cf54f82f710213c4033e75b83c366d0441 Mon Sep 17 00:00:00 2001 From: Patrick Steele-Idem Date: Thu, 26 Jan 2017 17:18:12 -0700 Subject: [PATCH] Fixes #549 - Migrate from "data" to "input" --- compiler/ast/TemplateRoot.js | 8 +++++--- .../autotests/render-deprecated/data/expected.html | 1 + .../render-deprecated/data/template.marko | 1 + test/autotests/render-deprecated/data/test.js | 3 +++ .../render/attr-boolean-dynamic/template.marko | 4 ++-- .../render/attr-boolean-placeholder/template.marko | 4 ++-- .../render/attr-empty-dynamic/template.marko | 2 +- .../render/attr-object-dynamic/template.marko | 2 +- .../template.marko | 2 +- .../template.marko | 2 +- .../template.marko | 2 +- .../attr-special-object-expression/template.marko | 2 +- test/autotests/render/attrs/template.marko | 2 +- .../components/test-hello/template.marko | 2 +- test/autotests/render/body-only-if/template.marko | 4 ++-- .../tags/navigation-item/template.marko | 2 +- .../circular-tags-no-write-to-disk/template.marko | 2 +- .../render/concise-verbose/template.marko | 6 +++--- test/autotests/render/concise/template.marko | 6 +++--- .../render/conditional-attributes/template.marko | 2 +- .../tags/test-template-as-tag/template.marko | 2 +- .../tags/test-tag/index.marko | 2 +- .../dynamic-attributes-string/template.marko | 2 +- .../render/dynamic-tag-name-concise/template.marko | 4 ++-- .../render/dynamic-tag-name/template.marko | 4 ++-- .../render/empty-close-tag/template.marko | 2 +- .../error-invalid-if-else-attr/template.marko | 2 +- .../render/error-invalid-if-else-attr/test.js | 2 +- .../error-invalid-if-else-if-attr/template.marko | 2 +- .../template.marko | 4 ++-- .../error-invalid-if-else-if-else-attr/test.js | 2 +- test/autotests/render/escape-script/template.marko | 4 ++-- .../render/for-iterator-as-target/template.marko | 2 +- .../render/for-iterator-attr/template.marko | 2 +- .../for-iterator-status-var-attr/template.marko | 2 +- .../render/for-iterator-status-var/template.marko | 2 +- test/autotests/render/for-iterator/template.marko | 2 +- test/autotests/render/for-props-map/template.marko | 2 +- .../render/for-tag-array-expression/template.marko | 2 +- test/autotests/render/function-tag/template.marko | 2 +- test/autotests/render/hello-dynamic/template.marko | 2 +- test/autotests/render/if-else-attr/template.marko | 2 +- .../render/if-else-if-attr/template.marko | 2 +- .../render/if-else-if-else-attr/template.marko | 4 ++-- .../render/include-attr/include-target.marko | 2 +- .../render/include-body-empty/include-target.marko | 6 +++--- .../render/include-body/include-target.marko | 4 ++-- .../render/include-component/template.marko | 2 +- .../render/include-data-body/include-target.marko | 4 ++-- .../render/include-data/include-target.marko | 2 +- .../render/include-dynamic/include-target.marko | 2 +- .../render/include-dynamic/template.marko | 2 +- .../include-target.marko | 2 +- .../include-hyphen-attrs/include-target.marko | 2 +- .../include-layout-data-attrs/layout-default.marko | 14 +++++++------- .../include-layout-data/layout-default.marko | 12 ++++++------ .../render/include-layout/layout-default.marko | 12 ++++++------ .../autotests/render/include-layout/template.marko | 2 +- .../template.marko | 2 +- .../include-renderBody-no-data/template.marko | 2 +- .../include-renderBody-string-arg/template.marko | 2 +- .../render/include-renderBody/template.marko | 2 +- .../render/include-whitespace/include-target.marko | 4 ++-- test/autotests/render/include/include-target.marko | 2 +- test/autotests/render/inline-script/template.marko | 4 ++-- .../marko-body-attr-parsed-text/template.marko | 2 +- .../components/test-message/template.marko | 6 +++--- .../components/test-message/template.marko | 2 +- .../components/test-message/template.marko | 4 ++-- .../components/test-message/template.marko | 4 ++-- .../components/test-message/template.marko | 4 ++-- .../components/test-message/template.marko | 4 ++-- .../components/test-message/template.marko | 2 +- .../components/test-message/template.marko | 2 +- .../components/test-message/template.marko | 4 ++-- .../tags/test-nested-tags-tabs/template.marko | 2 +- .../tags/test-nested-tags-deep/template.marko | 2 +- .../tags/test-nested-tags-tabs/template.marko | 2 +- .../tags/test-nested-tags-overlay/template.marko | 12 ++++++------ .../nested-tags-repeated-parent/template.marko | 2 +- .../tags/test-nested-tags-tabs/template.marko | 2 +- .../tags/test-nested-tags-tabs/template.marko | 2 +- .../tags/test-nested-tags-overlay/template.marko | 12 ++++++------ test/autotests/render/nested-tags/template.marko | 2 +- .../autotests/render/reserved-words/template.marko | 2 +- .../scanned-tags/tags/scanned-b/template.marko | 2 +- .../scanned-tags/tags/scanned-d/template.marko | 2 +- test/autotests/render/script-nonce/template.marko | 2 +- .../render/script-tag-entities/template.marko | 2 +- .../render/shorthand-class-merge2/template.marko | 2 +- .../shorthand-classes-many-classes/template.marko | 2 +- .../render/shorthand-div-id-dynamic/template.marko | 4 ++-- .../render/shorthand-div-id/template.marko | 2 +- .../render/shorthand-div.foo/template.marko | 2 +- .../render/shorthand-verbose/template.marko | 2 +- .../render/simple-conditionals/template.marko | 2 +- test/autotests/render/simple/template.marko | 6 +++--- .../render/string-expressions/template.marko | 2 +- .../style-attr-string-dynamic/template.marko | 2 +- .../render/syntax-concise/tabs/template.marko | 2 +- .../autotests/render/syntax-concise/template.marko | 4 ++-- .../render/syntax-mixed/tabs/template.marko | 2 +- test/autotests/render/syntax-mixed/template.marko | 4 ++-- .../render/syntax-simple-concise/template.marko | 6 +++--- .../render/syntax-simple-mixed/template.marko | 6 +++--- .../render/syntax-simple-verbose/template.marko | 6 +++--- .../render/syntax-verbose/tabs/template.marko | 2 +- .../autotests/render/syntax-verbose/template.marko | 4 ++-- .../tabs-tab-new/tags/test-tabs-new/template.marko | 2 +- test/autotests/render/tabs-tab-new/template.marko | 2 +- .../render/tabs-tab/tags/test-tabs/template.marko | 2 +- test/autotests/render/tabs-tab/template.marko | 2 +- .../tag-code-generator-return-array/template.marko | 2 +- .../tag-code-generator-return-node/template.marko | 2 +- .../tag-code-generator-return-self/template.marko | 2 +- .../tag-code-generator-return-tree/template.marko | 2 +- .../template.marko | 2 +- .../render/text-replacement/template.marko | 4 ++-- test/autotests/render/toHTML/template.marko | 2 +- .../transformer-dynamic-tag-name/template.marko | 2 +- test/autotests/render/xml-escaping/template.marko | 4 ++-- .../custom-events/components/app-bar/index.marko | 2 +- .../components/app-custom-events/index.marko | 2 +- .../components/app-simple/index.marko | 2 +- .../widgets-browser/destroy-widget/index.marko | 2 +- .../dom-events-repeated-el-bubbling/index.marko | 2 +- .../index.marko | 2 +- .../index.marko | 2 +- .../components/app-fancy-button/index.marko | 2 +- .../include-preserve-old/index.marko | 2 +- .../preserve-dom-body-no-id/index.marko | 6 +++--- .../widgets-browser/preserve-dom-body/index.marko | 6 +++--- .../widgets-browser/preserve-dom-no-id/index.marko | 6 +++--- .../widgets-browser/preserve-dom/index.marko | 6 +++--- .../widgets-browser/rerender-same-id/index.marko | 2 +- .../sanity-check-template-entry-split/index.marko | 2 +- .../transclusion-body-slot-attr/index.marko | 2 +- .../index.marko | 2 +- .../transclusion-body-slot-tag/index.marko | 2 +- .../transclusion-include-from-state/index.marko | 2 +- .../components/app-button/index.marko | 2 +- .../transclusion-include-not-in-state/index.marko | 2 +- .../update-manager-batch-updates/index.marko | 2 +- .../update-manager-next-tick/index.marko | 2 +- .../components/app-bar/index.marko | 2 +- .../components/app-custom-events/index.marko | 2 +- .../components/app-bar/index.marko | 2 +- .../components/app-custom-events/index.marko | 2 +- .../components/app-legacy-button/index.marko | 2 +- .../components/app-custom-events/index.marko | 2 +- .../components/app-legacy-button/index.marko | 2 +- .../widget-dynamic-tag-name/index.marko | 2 +- .../components/app-bar/index.marko | 2 +- .../widget-include-ref-dynamic/index.marko | 2 +- .../components/app-bar/index.marko | 2 +- .../widgets-browser/widget-include-ref/index.marko | 2 +- .../index.marko | 2 +- .../widget-lifecycle-events-stateful/index.marko | 6 +++--- .../widget-lifecycle-events-stateless/index.marko | 2 +- .../widget-no-update-attrs-dynamic/index.marko | 2 +- .../index.marko | 8 ++++---- .../index.marko | 8 ++++---- .../widget-preserve-dom-attrs-dynamic/index.marko | 2 +- .../widget-preserve-dom-attrs/index.marko | 4 ++-- .../components/app-stateful-rerender/index.marko | 8 ++++---- .../widget-preserve-dom-if/index.marko | 12 ++++++------ .../widget-preserve-dom-root/index.marko | 2 +- .../components/app-simple/index.marko | 2 +- .../widget-repeated-id-widgetless/index.marko | 2 +- .../app-rerender-init-order-child/index.marko | 2 +- .../widget-rerender-init-order/index.marko | 4 ++-- .../widget-rerender-reuse-stateful/index.marko | 2 +- .../index.marko | 2 +- .../widget-setStateDirty/index.marko | 2 +- .../components/app-stateful-button/index.marko | 2 +- .../widget-stateful-reuse-widgets/index.marko | 2 +- .../widget-stateful-update/index.marko | 2 +- test/browser-tests-runner/page-template.marko.js | 4 +++- 178 files changed, 277 insertions(+), 268 deletions(-) create mode 100644 test/autotests/render-deprecated/data/expected.html create mode 100644 test/autotests/render-deprecated/data/template.marko create mode 100644 test/autotests/render-deprecated/data/test.js diff --git a/compiler/ast/TemplateRoot.js b/compiler/ast/TemplateRoot.js index 81b9d8d63..153212259 100644 --- a/compiler/ast/TemplateRoot.js +++ b/compiler/ast/TemplateRoot.js @@ -38,7 +38,9 @@ class TemplateRoot extends Node { var builder = codegen.builder; - let renderStatements = []; + let renderStatements = [ + builder.var('data', builder.identifier('input')) + ]; var vars = createVarsArray(context.getVars()); if (vars.length) { renderStatements.push(builder.vars(vars)); @@ -56,7 +58,7 @@ class TemplateRoot extends Node { builder.functionDeclaration( null, [ - builder.identifier('data'), + builder.identifier('input'), builder.identifierOut() ], renderStatements) @@ -89,7 +91,7 @@ class TemplateRoot extends Node { body = body.concat(staticNodes); } - var renderParams = [builder.identifier('data'), builder.identifierOut()]; + var renderParams = [builder.identifier('input'), builder.identifierOut()]; if (this.extraRenderParams) { renderParams = renderParams.concat(this.extraRenderParams); } diff --git a/test/autotests/render-deprecated/data/expected.html b/test/autotests/render-deprecated/data/expected.html new file mode 100644 index 000000000..24a5b0935 --- /dev/null +++ b/test/autotests/render-deprecated/data/expected.html @@ -0,0 +1 @@ +Hello Frank! data===input ? true \ No newline at end of file diff --git a/test/autotests/render-deprecated/data/template.marko b/test/autotests/render-deprecated/data/template.marko new file mode 100644 index 000000000..d488b7a77 --- /dev/null +++ b/test/autotests/render-deprecated/data/template.marko @@ -0,0 +1 @@ +-- Hello ${data.name}! data===input ? ${data === input} \ No newline at end of file diff --git a/test/autotests/render-deprecated/data/test.js b/test/autotests/render-deprecated/data/test.js new file mode 100644 index 000000000..0266cde02 --- /dev/null +++ b/test/autotests/render-deprecated/data/test.js @@ -0,0 +1,3 @@ +exports.templateData = { + name: 'Frank' +}; diff --git a/test/autotests/render/attr-boolean-dynamic/template.marko b/test/autotests/render/attr-boolean-dynamic/template.marko index 1ff03738c..5fc74c4d4 100644 --- a/test/autotests/render/attr-boolean-dynamic/template.marko +++ b/test/autotests/render/attr-boolean-dynamic/template.marko @@ -1,5 +1,5 @@ \ No newline at end of file diff --git a/test/autotests/render/attr-boolean-placeholder/template.marko b/test/autotests/render/attr-boolean-placeholder/template.marko index 1d2864d69..a88abd18f 100644 --- a/test/autotests/render/attr-boolean-placeholder/template.marko +++ b/test/autotests/render/attr-boolean-placeholder/template.marko @@ -1,11 +1,11 @@ - +