Improvements to adjustIndent

compiler/util/adjustIndent.js

@@ -1,22 +1,52 @@
 var splitLinesRegExp = /\r?\n/;
 var initialIndentationRegExp = /^\s+/;
 
-// var initialSpaceMatches = /^\s+/.exec(text);
-//             if (initialSpaceMatches) {
-//                 var indentMatches = /\n[^\n]*$/.exec(initialSpaceMatches[0]);
-//                 if (indentMatches) {
-//                     var indentRegExp = new RegExp(indentMatches[0].replace(/\n/g, '\\n'), 'g');
-//                     text = text.replace(indentRegExp, '\n');
-//                 }
-//                 text = text.replace(/^\s*/, '').replace(/\s*$/, '');
-//                 this.setText(text);
-//             }
+function removeInitialEmptyLines(lines) {
+    var i;
+
+    for (i=0; i<lines.length; i++) {
+        if (lines[i].trim() !== '') {
+            break;
+        }
+    }
+
+    if (i !== 0) {
+        lines = lines.slice(i);
+    }
+
+    return lines;
+}
+
+function removeTrailingEmptyLines(lines) {
+    var i;
+    var last = lines.length-1;
+
+    for (i=last; i>=0; i--) {
+        if (lines[i].trim() !== '') {
+            break;
+        }
+    }
+
+    if (i !== last) {
+        lines = lines.slice(0, i+1);
+    }
+
+    return lines;
+}
+
 function adjustIndent(str, newIndentation) {
     if (!str) {
         return str;
     }
 
     var lines = str.split(splitLinesRegExp);
+    lines = removeInitialEmptyLines(lines);
+    lines = removeTrailingEmptyLines(lines);
+
+    if (lines.length === 0) {
+        return '';
+    }
+
     var initialIndentationMatches = initialIndentationRegExp.exec(lines[0]);
 
     var indentation = initialIndentationMatches ? initialIndentationMatches[0] : '';
@@ -33,37 +63,8 @@ function adjustIndent(str, newIndentation) {
     });
 
     return newIndentation ?
-        newIndentation + lines.join('\n' + newIndentation) :
+        lines.join('\n' + newIndentation) :
         lines.join('\n');
 }
 
-// function adjustIndent(str, newIndentation) {
-//     if (!str) {
-//         return str;
-//     }
-//
-//     var lines = str.split(splitLinesRegExp);
-//     var initialIndentationMatches = initialIndentationRegExp.exec(lines[0]);
-//
-//     var indentation = initialIndentationMatches ? initialIndentationMatches[0] : '';
-//     if (!indentation && !newIndentation) {
-//         return str;
-//     }
-//
-//     var result = '';
-//
-//     lines.forEach((line, i) => {
-//         if (line.startsWith(indentation)) {
-//             line = line.substring(indentation.length);
-//         }
-//
-//         if (newIndentation) {
-//             line = newIndentation + line;
-//         }
-//
-//         result += line + '\n';
-//     });
-//
-//     return result;
-// }
 module.exports = adjustIndent;

test/fixtures/adjustIndent/autotest/bad-indent/expected.txt

@@ -1,3 +1,3 @@
-    var foo = require('foo');
+var foo = require('foo');
     var bar = require('bar');
     var baz = require('baz');

test/fixtures/adjustIndent/autotest/increase-indent/expected.txt

@@ -1,2 +1,2 @@
-        var foo = require('foo');
+var foo = require('foo');
         var bar = require('bar');

test/fixtures/adjustIndent/autotest/initial-empty-lines/expected.txt

@@ -0,0 +1,3 @@
+var foo = require('foo');
+        var bar = require('bar');
+        var baz = require('baz');

test/fixtures/adjustIndent/autotest/initial-empty-lines/input.txt

@@ -0,0 +1,5 @@
+
+
+	var foo = require('foo');
+	var bar = require('bar');
+	var baz = require('baz');

test/fixtures/adjustIndent/autotest/initial-empty-lines/test.js

@@ -0,0 +1 @@
+exports.newIndentation = '        ';

test/fixtures/adjustIndent/autotest/no-indent/expected.txt

@@ -1,3 +1,3 @@
-    var foo = require('foo');
+var foo = require('foo');
     var bar = require('bar');
     var baz = require('baz');

test/fixtures/adjustIndent/autotest/surrounding-empty-lines/expected.txt

@@ -0,0 +1,3 @@
+var foo = require('foo');
+        var bar = require('bar');
+        var baz = require('baz');

test/fixtures/adjustIndent/autotest/surrounding-empty-lines/input.txt

@@ -0,0 +1,6 @@
+
+
+	var foo = require('foo');
+	var bar = require('bar');
+	var baz = require('baz');
+

test/fixtures/adjustIndent/autotest/surrounding-empty-lines/test.js

@@ -0,0 +1 @@
+exports.newIndentation = '        ';

test/fixtures/adjustIndent/autotest/tab-indent/expected.txt

@@ -1,3 +1,3 @@
-        var foo = require('foo');
+var foo = require('foo');
         var bar = require('bar');
         var baz = require('baz');

test/fixtures/adjustIndent/autotest/trailing-empty-lines/expected.txt

@@ -0,0 +1,3 @@
+var foo = require('foo');
+        var bar = require('bar');
+        var baz = require('baz');

test/fixtures/adjustIndent/autotest/trailing-empty-lines/input.txt

@@ -0,0 +1,4 @@
+	var foo = require('foo');
+	var bar = require('bar');
+	var baz = require('baz');
+	

test/fixtures/adjustIndent/autotest/trailing-empty-lines/test.js

@@ -0,0 +1 @@
+exports.newIndentation = '        ';