archive-gh-me/marko
1
0
Fork 0
mirror of https://github.com/marko-js/marko.git synced 2025-12-08 19:26:05 +00:00
Code Issues Projects Releases Wiki Activity

fix: handle errors thrown in await catch attrs

Browse Source
This commit is contained in:
Ryan Turnquist 2023-07-26 10:19:59 -07:00 committed by Dylan Piercey
parent 59dd026483
commit 4286236b0e
4 changed files with 30 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
.changeset/gold-timers-sleep.md Normal file
View File

@ -0,0 +1,5 @@
---
"marko": patch
---
Handle errors thrown in await catch attribute

6
packages/marko/src/core-tags/core/await/renderer.js
View File

@ -220,7 +220,11 @@ function renderContents(err, data, input, out) {
if (err) {
if (input.catch) {
if (errorRenderer) {
errorRenderer(out, err);
try {
errorRenderer(out, err);
} catch (err2) {
out.error(err2);
}
}
} else {
out.error(err);

10
packages/marko/test/render/fixtures/await-error-rethrow-catch/template.marko Normal file
View File

@ -0,0 +1,10 @@
---
BEFORE
<await(Promise.reject(new Error("Something went wrong!")))>
<@then|testData|>Success!</@then>
<@catch|err|>
$ throw err
</@catch>
</await>
AFTER
---

10
packages/marko/test/render/fixtures/await-error-rethrow-catch/test.js Normal file
View File

@ -0,0 +1,10 @@
var expect = require("chai").expect;
exports.templateData = {};
exports.skip_vdom = "VDOM does not support async components";
exports.checkError = function (e) {
var message = e.toString();
expect(message).to.contain("Something went wrong");
};