archive-gh-me/marko
1
0
Fork 0
mirror of https://github.com/marko-js/marko.git synced 2025-12-08 19:26:05 +00:00
Code Issues Projects Releases Wiki Activity

Marko v3: Don't render attribute value if it is an empty string

Browse Source
This commit is contained in:
Patrick Steele-Idem 2016-01-11 09:59:49 -07:00
parent 0e9d9652a3
commit 1ed8881b4d
4 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
compiler/ast/HtmlAttribute.js
View File

@ -180,8 +180,8 @@ class HtmlAttribute extends Node {
if (this.isLiteralValue()) { if (this.isLiteralValue()) {
var literalValue = value.value; var literalValue = value.value;
if (typeof literalValue === 'boolean') { if (typeof literalValue === 'boolean' || literalValue === '') {
if (literalValue === true) { if (literalValue === true || literalValue === '') {
codegen.addWriteLiteral(' ' + name); codegen.addWriteLiteral(' ' + name);
} }
} else if (literalValue != null) { } else if (literalValue != null) {

0
test/fixtures/render/autotest-pending/empty-attr/expected.html → test/fixtures/render/autotest/attr-empty/expected.html vendored
View File

0
test/fixtures/render/autotest-pending/empty-attr/template.marko → test/fixtures/render/autotest/attr-empty/template.marko vendored
View File

0
test/fixtures/render/autotest-pending/empty-attr/test.js → test/fixtures/render/autotest/attr-empty/test.js vendored
View File