archive-gh-me/marko
1
0
Fork 0
mirror of https://github.com/marko-js/marko.git synced 2025-12-08 19:26:05 +00:00
Code Issues Projects Releases Wiki Activity

Fixes #705 - Throw error when the root HTML element is a component and has a dynamic id attribute.

Browse Source
This commit is contained in:
Austin Kelleher 2017-06-12 14:05:35 -04:00
parent 7aac3aae38
commit 11580da273
6 changed files with 23 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/components/taglib/TransformHelper/handleRootNodes.js
View File

@ -266,6 +266,13 @@ module.exports = function handleRootNodes() {
var nextKey = 0;
rootNodes.forEach((curNode, i) => {
let id = curNode.getAttributeValue('id');
if (id && id.type !== 'Literal') {
context.addError('Root HTML element should not have a dynamic `id` attribute. See: https://github.com/marko-js/marko/wiki/Error:-Dynamic-root-HTML-element-id-attribute');
return;
}
curNode.setFlag('hasComponentBind');
if (!curNode.hasAttribute('key') && !curNode.hasAttribute('ref')) {

5
test/autotests/render/error-variable-id-root-node-component/template.marko Normal file
View File

@ -0,0 +1,5 @@
class {}
$ var id = 'abc123';
<div id=id/>

6
test/autotests/render/error-variable-id-root-node-component/test.js Normal file
View File

@ -0,0 +1,6 @@
var expect = require('chai').expect;
exports.checkError = function(e) {
var message = e.toString();
expect(message).to.contain('https://github.com/marko-js/marko/wiki/Error:-Dynamic-root-HTML-element-id-attribute');
};

1
test/autotests/render/variable-id-root-node/expected.html Normal file
View File

@ -0,0 +1 @@
<div id="abc123"></div>

3
test/autotests/render/variable-id-root-node/template.marko Normal file
View File

@ -0,0 +1,3 @@
$ var id = 'abc123';
<div id=id/>

1
test/autotests/render/variable-id-root-node/test.js Normal file
View File

@ -0,0 +1 @@
exports.templateData = {};