archive-gh-me/marko
1
0
Fork 0
mirror of https://github.com/marko-js/marko.git synced 2025-12-08 19:26:05 +00:00
Code Issues Projects Releases Wiki Activity

fix: controlled details and dialog elements

Browse Source
This commit is contained in:
dpiercey 2025-02-04 14:49:07 -07:00 committed by Dylan Piercey
parent 27e65800a1
commit 07f97f187a
4 changed files with 12 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
.changeset/moody-chairs-beam.md Normal file
View File

@ -0,0 +1,5 @@
---
"@marko/runtime-tags": patch
---
Fix issue where details and dialog elements were incorrectly running change handlers when the value had not changed.

2
.sizes.json
View File

@ -7,7 +7,7 @@
{
"name": "*",
"total": {
"min": 18364,
"min": 18373,
"brotli": 6749
}
},

5
.sizes/dom.js
View File

@ -1,4 +1,4 @@
// size: 18364 (min) 6749 (brotli)
// size: 18373 (min) 6749 (brotli)
var empty = [],
rest = Symbol();
function attrTag(attrs2) {
@ -446,7 +446,8 @@ function controllable_detailsOrDialog_open(
) {
(scope[nodeAccessor + ";"] = openChange),
(scope[nodeAccessor + "="] = openChange ? 4 : 5),
(scope[nodeAccessor].open = normalizeBoolProp(open));
(scope[nodeAccessor].open = scope[nodeAccessor + ":"] =
normalizeBoolProp(open));
}
function controllable_detailsOrDialog_open_effect(scope, nodeAccessor) {
let el = scope[nodeAccessor],

4
packages/runtime-tags/src/dom/controllable.ts
View File

@ -259,7 +259,9 @@ export function controllable_detailsOrDialog_open(
scope[nodeAccessor + AccessorChar.ControlledType] = ControlledType.None;
}
(scope[nodeAccessor] as HTMLDetailsElement).open = normalizeBoolProp(open);
(scope[nodeAccessor] as HTMLDetailsElement).open = scope[
nodeAccessor + AccessorChar.ControlledValue
] = normalizeBoolProp(open);
}
export function controllable_detailsOrDialog_open_effect(
scope: Scope,