archive-gh-me/luma.gl
1
0
Fork 0
mirror of https://github.com/visgl/luma.gl.git synced 2026-02-01 14:33:49 +00:00
Code Issues Projects Releases Wiki Activity

Revert "bug(engine) Handle null/undefined in attribute debug (#1921)" (#1924)

Browse Source
This commit is contained in:
felixpalmer 2024-01-18 11:01:27 +01:00 committed by GitHub
parent 49aa22851d
commit a382dcd888
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 0 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
modules/engine/src/model/model.ts
View File

@ -611,13 +611,6 @@ export class Model {
// TODO - fix typing of luma data types
_getBufferOrConstantValues(attribute: Buffer | TypedArray, dataType: any): string {
if (attribute === null) {
log.warn('Missing attribute')();
return 'null';
} else if (attribute === undefined) {
log.warn('Missing attribute')();
return 'undefined';
}
const TypedArrayConstructor = getTypedArrayFromDataType(dataType);
const typedArray =
attribute instanceof Buffer ? new TypedArrayConstructor(attribute.debugData) : attribute;