From ec0fd992a819552ed8befa0e61a8470a768ed1d3 Mon Sep 17 00:00:00 2001 From: e-cloud Date: Fri, 15 Jul 2016 20:34:51 +0800 Subject: [PATCH] refactor: appenders/logFacesAppender.js --- lib/appenders/logFacesAppender.js | 61 ++++++++++++++----------------- 1 file changed, 28 insertions(+), 33 deletions(-) diff --git a/lib/appenders/logFacesAppender.js b/lib/appenders/logFacesAppender.js index ad88cfe..6df3a62 100644 --- a/lib/appenders/logFacesAppender.js +++ b/lib/appenders/logFacesAppender.js @@ -10,34 +10,25 @@ * - message text */ -"use strict"; -var dgram = require('dgram'), - layouts = require('../layouts'), - os = require('os'), - util = require('util'); - -try { - var process = require('process'); -} -catch (error) { - //this module is optional as it may not be available - //in older versions of node.js, so ignore if it failes to load -} +'use strict'; +const dgram = require('dgram'); +const layouts = require('../layouts'); +const os = require('os'); +const util = require('util'); function logFacesAppender(config, layout) { - var lfsSock = dgram.createSocket('udp4'); - var localhost = ""; + const lfsSock = dgram.createSocket('udp4'); + let localhost = ''; - if (os && os.hostname()) - localhost = os.hostname().toString(); + if (os && os.hostname()) localhost = os.hostname().toString(); - var pid = ""; - if (process && process.pid) - pid = process.pid; + let pid; + + if (process && process.pid) pid = process.pid; return function log(loggingEvent) { - var lfsEvent = { - a: config.application || "", // application name + const lfsEvent = { + a: config.application || '', // application name h: localhost, // this host name t: loggingEvent.startTime.getTime(), // time stamp p: loggingEvent.level.levelStr, // level (priority) @@ -46,12 +37,14 @@ function logFacesAppender(config, layout) { m: layout(loggingEvent) // message text }; - var buffer = new Buffer(JSON.stringify(lfsEvent)); - var lfsHost = config.remoteHost || "127.0.0.1"; - var lfsPort = config.port || 55201; - lfsSock.send(buffer, 0, buffer.length, lfsPort, lfsHost, function (err, bytes) { + const buffer = new Buffer(JSON.stringify(lfsEvent)); + const lfsHost = config.remoteHost || '127.0.0.1'; + const lfsPort = config.port || 55201; + + /* eslint no-unused-vars:0 */ + lfsSock.send(buffer, 0, buffer.length, lfsPort, lfsHost, (err, bytes) => { if (err) { - console.error("log4js.logFacesAppender send to %s:%d failed, error: %s", + console.error('log4js.logFacesAppender send to %s:%d failed, error: %s', config.host, config.port, util.inspect(err)); } }); @@ -59,13 +52,15 @@ function logFacesAppender(config, layout) { } function configure(config) { - var layout; - if (config.layout) + let layout; + if (config.layout) { layout = layouts.layout(config.layout.type, config.layout); - else - layout = layouts.layout("pattern", { "type": "pattern", "pattern": "%m" }); + } else { + layout = layouts.layout('pattern', { type: 'pattern', pattern: '%m' }); + } + return logFacesAppender(config, layout); } -exports.appender = logFacesAppender; -exports.configure = configure; +module.exports.appender = logFacesAppender; +module.exports.configure = configure;