archive-gh-me/log4js-node
1
0
Fork 0
mirror of https://github.com/log4js-node/log4js-node.git synced 2025-12-08 19:26:01 +00:00
Code Issues Projects Releases Wiki Activity

fix(LoggingEvent): serde for object with null prototype

Browse Source
This commit is contained in:
Lam Wei Li 2024-04-04 15:22:07 +08:00
parent f5cac419c5
commit e1efb82829
No known key found for this signature in database
GPG Key ID: 90F6ABECF080D7BF
2 changed files with 14 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lib/LoggingEvent.js
View File

@ -22,7 +22,11 @@ class SerDe {
canSerialise(key) {
if (typeof key === 'string') return false;
return key in this.serMap;
try {
return key in this.serMap;
} catch (e) {
return false;
}
}
serialise(key) {

10
test/tap/LoggingEvent-test.js
View File

@ -20,6 +20,8 @@ test('LoggingEvent', (batch) => {
});
batch.test('should serialise to flatted', (t) => {
const nullPrototype = Object.create(null);
nullPrototype.hello = 'world';
const event = new LoggingEvent(
'cheese',
levels.DEBUG,
@ -33,6 +35,7 @@ test('LoggingEvent', (batch) => {
'-Infinity',
undefined,
'undefined',
nullPrototype,
],
{
user: 'bob',
@ -44,7 +47,7 @@ test('LoggingEvent', (batch) => {
t.equal(rehydratedEvent.startTime, '2018-02-04T18:30:23.010Z');
t.equal(rehydratedEvent.categoryName, 'cheese');
t.equal(rehydratedEvent.level.levelStr, 'DEBUG');
t.equal(rehydratedEvent.data.length, 9);
t.equal(rehydratedEvent.data.length, 10);
t.equal(rehydratedEvent.data[0], 'log message');
t.equal(rehydratedEvent.data[1], '__LOG4JS_NaN__');
t.equal(rehydratedEvent.data[2], 'NaN');
@ -54,6 +57,11 @@ test('LoggingEvent', (batch) => {
t.equal(rehydratedEvent.data[6], '-Infinity');
t.equal(rehydratedEvent.data[7], '__LOG4JS_undefined__');
t.equal(rehydratedEvent.data[8], 'undefined');
t.equal(
Object.entries(rehydratedEvent.data[9]).length,
Object.entries(nullPrototype).length
);
t.equal(rehydratedEvent.data[9].hello, 'world');
t.equal(rehydratedEvent.context.user, 'bob');
t.end();
});