diff --git a/lib/appenders/file.js b/lib/appenders/file.js index 0275446..a7f1bad 100644 --- a/lib/appenders/file.js +++ b/lib/appenders/file.js @@ -3,7 +3,7 @@ const path = require('path'); const streams = require('streamroller'); const os = require('os'); -const eol = os.EOL || '\n'; +const eol = os.EOL; function openTheStream(file, fileSize, numFiles, options) { const stream = new streams.RollingFileStream( diff --git a/test/tap/pause-test.js b/test/tap/pause-test.js index f6db91c..8e73758 100644 --- a/test/tap/pause-test.js +++ b/test/tap/pause-test.js @@ -4,31 +4,32 @@ const log4js = require("../../lib/log4js"); tap.test("Drain event test", batch => { batch.test("Should emit pause event and resume when logging in a file with high frequency", t => { - // Generate logger with 5MB of highWaterMark config + // Generate logger with 5k of highWaterMark config log4js.configure({ appenders: { - file: { type: "file", filename: "logs/drain.log", highWaterMark: 5 * 1024 * 1024 } + file: { type: "file", filename: "logs/drain.log", highWaterMark: 5 * 1024 } }, categories: { default: { appenders: ["file"], level: "debug" } } }); - let onPause = false; - let onResume = false; + let paused = false; + let resumed = false; process.on("log4js:pause", value => { if (value) { - onPause = true; + paused = true; } else { - onResume = true; + resumed = true; } }); const logger = log4js.getLogger(); - while (onPause === false && onResume === false) { - if (onPause === false) + while (!paused && !resumed) { + if (!paused) { logger.info("This is a test for emitting drain event"); + } } t.end(); });