From a0baec23a84684d998ab4c704b1f19603550e3fa Mon Sep 17 00:00:00 2001 From: Lam Wei Li Date: Wed, 19 Jan 2022 09:24:55 +0800 Subject: [PATCH] chore(test): fixed teardown() causing tests to fail due to fs errors on removal --- test/tap/multi-file-appender-test.js | 10 ++++++++-- test/tap/pause-test.js | 11 ++++++++--- 2 files changed, 16 insertions(+), 5 deletions(-) diff --git a/test/tap/multi-file-appender-test.js b/test/tap/multi-file-appender-test.js index 5df3200..aa93f7c 100644 --- a/test/tap/multi-file-appender-test.js +++ b/test/tap/multi-file-appender-test.js @@ -236,8 +236,14 @@ test("multiFile appender", batch => { }); }); - batch.tearDown(() => { - fs.rmdirSync("logs"); + batch.tearDown(async () => { + try { + const files = fs.readdirSync("logs"); + await removeFiles(files.map(filename => `logs/${filename}`)); + fs.rmdirSync("logs"); + } catch (e) { + // doesn't matter + } }); batch.end(); diff --git a/test/tap/pause-test.js b/test/tap/pause-test.js index f405d0e..37d1230 100644 --- a/test/tap/pause-test.js +++ b/test/tap/pause-test.js @@ -77,11 +77,16 @@ tap.test("Drain event test", batch => { logger.info("This is a test for emitting drain event in date file logger"); } t.end(); - }); - batch.tearDown(() => { - fs.rmdirSync("logs"); + batch.tearDown(async () => { + try { + const files = fs.readdirSync("logs"); + await removeFiles(files.map(filename => `logs/${filename}`)); + fs.rmdirSync("logs"); + } catch (e) { + // doesn't matter + } }); batch.end();