archive-gh-me/log4js-node
1
0
Fork 0
mirror of https://github.com/log4js-node/log4js-node.git synced 2025-12-08 19:26:01 +00:00
Code Issues Projects Releases Wiki Activity

chore(test): updated multiFileAppender tests' teardown() to reinstate debug and process.stderr.write

Browse Source
This commit is contained in:
Lam Wei Li 2022-03-15 15:43:47 +08:00
parent 7534f9c25f
commit 63b8f5367a
No known key found for this signature in database
GPG Key ID: 90F6ABECF080D7BF
1 changed files with 39 additions and 35 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

74
test/tap/multi-file-appender-test.js
View File

@ -74,10 +74,6 @@ test("multiFile appender", batch => {
); );
batch.test("should close file after timeout", t => { batch.test("should close file after timeout", t => {
t.teardown(async () => {
await new Promise(resolve => { log4js.shutdown(resolve); });
await removeFiles("logs/C.log");
});
/* checking that the file is closed after a timeout is done by looking at the debug logs /* checking that the file is closed after a timeout is done by looking at the debug logs
since detecting file locks with node.js is platform specific. since detecting file locks with node.js is platform specific.
*/ */
@ -90,7 +86,16 @@ test("multiFile appender", batch => {
originalWrite.apply(process.stderr, [string, encoding, fd]); originalWrite.apply(process.stderr, [string, encoding, fd]);
} }
}; };
debug.enable("log4js:multiFile"); const originalNamespace = debug.disable();
debug.enable(`${originalNamespace}, log4js:multiFile`);
t.teardown(async () => {
await new Promise(resolve => { log4js.shutdown(resolve); });
await removeFiles("logs/C.log");
process.stderr.write = originalWrite;
debug.enable(originalNamespace);
});
const timeoutMs = 25; const timeoutMs = 25;
log4js.configure({ log4js.configure({
appenders: { appenders: {
@ -113,19 +118,11 @@ test("multiFile appender", batch => {
`C not used for > ${timeoutMs} ms => close`, `C not used for > ${timeoutMs} ms => close`,
"(timeout1) should have closed" "(timeout1) should have closed"
); );
if (!debugWasEnabled) {
debug.disable("log4js:multiFile");
}
process.stderr.write = originalWrite;
t.end(); t.end();
}, timeoutMs*1 + 50); // add a 50 ms delay }, timeoutMs*1 + 50); // add a 50 ms delay
}); });
batch.test("should close file safely after timeout", t => { batch.test("should close file safely after timeout", t => {
t.teardown(async () => {
await new Promise(resolve => { sandboxedLog4js.shutdown(resolve); }); // eslint-disable-line no-use-before-define
await removeFiles("logs/C.log");
});
const error = new Error("fileAppender shutdown error"); const error = new Error("fileAppender shutdown error");
const sandboxedLog4js = sandbox.require("../../lib/log4js", { const sandboxedLog4js = sandbox.require("../../lib/log4js", {
requires: { requires: {
@ -157,7 +154,16 @@ test("multiFile appender", batch => {
originalWrite.apply(process.stderr, [string, encoding, fd]); originalWrite.apply(process.stderr, [string, encoding, fd]);
} }
}; };
debug.enable("log4js:multiFile"); const originalNamespace = debug.disable();
debug.enable(`${originalNamespace}, log4js:multiFile`);
t.teardown(async () => {
await new Promise(resolve => { sandboxedLog4js.shutdown(resolve); });
await removeFiles("logs/C.log");
process.stderr.write = originalWrite;
debug.enable(originalNamespace);
});
const timeoutMs = 25; const timeoutMs = 25;
sandboxedLog4js.configure({ sandboxedLog4js.configure({
appenders: { appenders: {
@ -185,19 +191,11 @@ test("multiFile appender", batch => {
`ignore error on file shutdown: ${error.message}`, `ignore error on file shutdown: ${error.message}`,
"safely shutdown" "safely shutdown"
); );
if (!debugWasEnabled) {
debug.disable("log4js:multiFile");
}
process.stderr.write = originalWrite;
t.end(); t.end();
}, timeoutMs*1 + 50); // add a 50 ms delay }, timeoutMs*1 + 50); // add a 50 ms delay
}); });
batch.test("should close file after extended timeout", t => { batch.test("should close file after extended timeout", t => {
t.teardown(async () => {
await new Promise(resolve => { log4js.shutdown(resolve); });
await removeFiles("logs/D.log");
});
/* checking that the file is closed after a timeout is done by looking at the debug logs /* checking that the file is closed after a timeout is done by looking at the debug logs
since detecting file locks with node.js is platform specific. since detecting file locks with node.js is platform specific.
*/ */
@ -210,7 +208,16 @@ test("multiFile appender", batch => {
originalWrite.apply(process.stderr, [string, encoding, fd]); originalWrite.apply(process.stderr, [string, encoding, fd]);
} }
}; };
debug.enable("log4js:multiFile"); const originalNamespace = debug.disable();
debug.enable(`${originalNamespace}, log4js:multiFile`);
t.teardown(async () => {
await new Promise(resolve => { log4js.shutdown(resolve); });
await removeFiles("logs/D.log");
process.stderr.write = originalWrite;
debug.enable(originalNamespace);
});
const timeoutMs = 100; const timeoutMs = 100;
log4js.configure({ log4js.configure({
appenders: { appenders: {
@ -247,18 +254,11 @@ test("multiFile appender", batch => {
`D not used for > ${timeoutMs} ms => close`, `D not used for > ${timeoutMs} ms => close`,
"(timeout2) should have closed" "(timeout2) should have closed"
); );
if (!debugWasEnabled) {
debug.disable("log4js:multiFile");
}
process.stderr.write = originalWrite;
t.end(); t.end();
}, timeoutMs*2 + 50); // add a 50 ms delay }, timeoutMs*2 + 50); // add a 50 ms delay
}); });
batch.test("should clear interval for active timers on shutdown", t => { batch.test("should clear interval for active timers on shutdown", t => {
t.teardown(async () => {
await removeFiles("logs/D.log");
});
/* checking that the file is closed after a timeout is done by looking at the debug logs /* checking that the file is closed after a timeout is done by looking at the debug logs
since detecting file locks with node.js is platform specific. since detecting file locks with node.js is platform specific.
*/ */
@ -271,7 +271,15 @@ test("multiFile appender", batch => {
originalWrite.apply(process.stderr, [string, encoding, fd]); originalWrite.apply(process.stderr, [string, encoding, fd]);
} }
}; };
debug.enable("log4js:multiFile"); const originalNamespace = debug.disable();
debug.enable(`${originalNamespace}, log4js:multiFile`);
t.teardown(async () => {
await removeFiles("logs/D.log");
process.stderr.write = originalWrite;
debug.enable(originalNamespace);
});
const timeoutMs = 100; const timeoutMs = 100;
log4js.configure({ log4js.configure({
appenders: { appenders: {
@ -302,10 +310,6 @@ test("multiFile appender", batch => {
"calling shutdown for D", "calling shutdown for D",
"should have called shutdown" "should have called shutdown"
); );
if (!debugWasEnabled) {
debug.disable("log4js:multiFile");
}
process.stderr.write = originalWrite;
t.end(); t.end();
}); });
}); });