archive-gh-me/log4js-node
1
0
Fork 0
mirror of https://github.com/log4js-node/log4js-node.git synced 2025-12-08 19:26:01 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #1254 from log4js-node/feat/logger.log-synonym

Browse Source 
feat: `logger.log()` to be synonym of `logger.info()`
This commit is contained in:
Lam Wei Li 2022-05-22 18:13:51 +08:00 committed by GitHub
commit 59f3f46c9c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 22 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
lib/logger.js
View File

@ -82,9 +82,15 @@ class Logger {
log(level, ...args) {
let logLevel = levels.getLevel(level);
if (!logLevel) {
this._log(levels.WARN, ['log4js:logger.log: invalid value for log-level as first parameter given:', level]);
// allow LOG to be synonym of INFO
if ((level && level.trim().indexOf(" ") !== -1) || args.length === 0) {
args = [level, ...args];
} else {
this._log(levels.WARN, ['log4js:logger.log: invalid value for log-level as first parameter given:', level]);
args = [`[${level}]`, ...args];
}
// fallback to INFO
logLevel = levels.INFO;
args = [level, ...args];
}
if (this.isLevelEnabled(logLevel)) {
this._log(logLevel, args);

22
test/tap/newLevel-test.js
View File

@ -232,9 +232,13 @@ test("../../lib/logger", batch => {
const logger = log4js.getLogger();
// fallback behavior
logger.log("LEVEL_DOES_NOT_EXIST", "Event 1");
logger.log(log4js.levels.getLevel("LEVEL_DOES_NOT_EXIST"), "Event 2");
logger.log(log4js.levels.getLevel("LEVEL_DOES_NOT_EXIST"), "Event 2", "2 Text");
// synonym behavior
logger.log("Event 3");
logger.log("Event 4", "4 Text");
const events = recording.replay();
@ -242,21 +246,23 @@ test("../../lib/logger", batch => {
t.equal(events[0].data[0], "log4js:logger.log: invalid value for log-level as first parameter given:");
t.equal(events[0].data[1], "LEVEL_DOES_NOT_EXIST");
t.equal(events[1].level.toString(), "INFO", "should fall back to INFO");
t.equal(events[1].data[0], "LEVEL_DOES_NOT_EXIST");
t.equal(events[1].data[0], "[LEVEL_DOES_NOT_EXIST]");
t.equal(events[1].data[1], "Event 1");
t.equal(events[2].level.toString(), "WARN", "should log warning");
t.equal(events[2].data[0], "log4js:logger.log: invalid value for log-level as first parameter given:");
t.equal(events[2].data[1], undefined);
t.equal(events[3].level.toString(), "INFO", "should fall back to INFO");
t.equal(events[3].data[0], undefined);
t.equal(events[3].data[0], "[undefined]");
t.equal(events[3].data[1], "Event 2");
t.equal(events[3].data[2], "2 Text");
t.equal(events[4].level.toString(), "WARN", "should log warning");
t.equal(events[4].data[0], "log4js:logger.log: invalid value for log-level as first parameter given:");
t.equal(events[4].data[1], "Event 3");
t.equal(events[5].level.toString(), "INFO", "should fall back to INFO");
t.equal(events[5].data[0], "Event 3");
t.equal(events[4].level.toString(), "INFO", "LOG is synonym of INFO");
t.equal(events[4].data[0], "Event 3");
t.equal(events[5].level.toString(), "INFO", "LOG is synonym of INFO");
t.equal(events[5].data[0], "Event 4");
t.equal(events[5].data[1], "4 Text");
t.end();
});