From 3de180710dce3a314fa7e40d6efde6b91273ba82 Mon Sep 17 00:00:00 2001 From: Gareth Jones Date: Fri, 14 Jul 2017 08:50:41 +1000 Subject: [PATCH] fix(#501): don't break when objects are weird --- lib/logger.js | 2 +- test/tap/logger-test.js | 9 +++++++++ 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/lib/logger.js b/lib/logger.js index 9db59e5..d4a14db 100644 --- a/lib/logger.js +++ b/lib/logger.js @@ -84,7 +84,7 @@ module.exports = function (levels, getLevelForCategory, setLevelForCategory) { } _log(level, data) { - debug(`sending log data (${level}, ${data}) to appenders`); + debug(`sending log data (${level}) to appenders`); const loggingEvent = new LoggingEvent(this.category, level, data, this.context); this.dispatch(loggingEvent); } diff --git a/test/tap/logger-test.js b/test/tap/logger-test.js index 4c706c6..c4ff6ed 100644 --- a/test/tap/logger-test.js +++ b/test/tap/logger-test.js @@ -120,5 +120,14 @@ test('../../lib/logger', (batch) => { t.end(); }); + batch.test('should not break when log data has no toString', (t) => { + const logger = new Logger(dispatch, 'thing'); + logger.info('Just testing ', Object.create(null)); + + const events = testDispatcher.events; + t.equal(events.length, 1); + t.end(); + }); + batch.end(); });