From b12200fabc9c9e64ba2f4cb4afe983aa3489430a Mon Sep 17 00:00:00 2001 From: Ryan Wilson Date: Fri, 20 Jun 2014 13:16:23 -0700 Subject: [PATCH 1/3] Update for "write after end" uncaught error. --- lib/streams/BaseRollingFileStream.js | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/lib/streams/BaseRollingFileStream.js b/lib/streams/BaseRollingFileStream.js index 5f03615..26de2b0 100644 --- a/lib/streams/BaseRollingFileStream.js +++ b/lib/streams/BaseRollingFileStream.js @@ -48,7 +48,14 @@ BaseRollingFileStream.prototype._write = function(chunk, encoding, callback) { function writeTheChunk() { debug("writing the chunk to the underlying stream"); that.currentSize += chunk.length; - that.theStream.write(chunk, encoding, callback); + if(that.theStream.writeable) { + try { + that.theStream.write(chunk, encoding, callback); + } + catch (err){ + callback(); + } + } } debug("in _write"); From 7d50b4aeff8d48d4597c09aa7953a57ad80989b2 Mon Sep 17 00:00:00 2001 From: Ryan Wilson Date: Fri, 20 Jun 2014 13:23:09 -0700 Subject: [PATCH 2/3] removed check for writeable caused broken unit tests --- lib/streams/BaseRollingFileStream.js | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/lib/streams/BaseRollingFileStream.js b/lib/streams/BaseRollingFileStream.js index 26de2b0..3f872ed 100644 --- a/lib/streams/BaseRollingFileStream.js +++ b/lib/streams/BaseRollingFileStream.js @@ -48,13 +48,13 @@ BaseRollingFileStream.prototype._write = function(chunk, encoding, callback) { function writeTheChunk() { debug("writing the chunk to the underlying stream"); that.currentSize += chunk.length; - if(that.theStream.writeable) { - try { - that.theStream.write(chunk, encoding, callback); - } - catch (err){ - callback(); - } + console.log(that.theStream); + try { + that.theStream.write(chunk, encoding, callback); + } + catch (err){ + debug(err); + callback(); } } From f8ffccffd5d5a2f04be3df8cc7b52ef80f2bc621 Mon Sep 17 00:00:00 2001 From: Ryan Wilson Date: Fri, 20 Jun 2014 13:23:57 -0700 Subject: [PATCH 3/3] epic day with a forgotten console --- lib/streams/BaseRollingFileStream.js | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/streams/BaseRollingFileStream.js b/lib/streams/BaseRollingFileStream.js index 3f872ed..572794c 100644 --- a/lib/streams/BaseRollingFileStream.js +++ b/lib/streams/BaseRollingFileStream.js @@ -48,7 +48,6 @@ BaseRollingFileStream.prototype._write = function(chunk, encoding, callback) { function writeTheChunk() { debug("writing the chunk to the underlying stream"); that.currentSize += chunk.length; - console.log(that.theStream); try { that.theStream.write(chunk, encoding, callback); }