As written it was a bit confusing the exact change that needed to be made, so I dug into the example code to look up where it was to go. The main bit of confusion was the name of the test changed.
I've added the rest of the function around the previous code snippet to add additional context
For clarity added the package and import lines for this new file. Saves the reader looking it up if unsure or if their IDE doesn't support import autocompletion.
Issue Link: https://github.com/quii/learn-go-with-tests/issues/353
Modifications:
* Modified the build script to download and run the gofmtmd tool on the markdown files
* Ran the script locally and fixed the issues reported by gofmtmd tool
Note: Intro to generics md file contains some syntax related to generics which is not recognised by the tool. So some valid
code fences are not marked as go
* Update maps.md
Rogue parenthesis in refactor example
* Documentation Updates
* tab->spaces
* Removed an option that wasn't an option, just a description of the current state of affairs
* Char formatting better with exclamation mark italicised
* Update outdated descriptions and links (#358)
* Update reflection.md (#361)
Code examples for chan and func are incorrect
* Update select.md (#371)
Hi all,
I've been following this repo to help teach myself go and it's been a great help.
I noticed on line 399 the first argument in t.Run doesn't match the assertion. Raising this PR for your consideration as to whether you think this wording fits better or not.
* specifying what files need to be created
* adding final file comments to http chapter
* typo fixes
Co-authored-by: 森 優太 mori <59682979+uta-mori@users.noreply.github.com>
Co-authored-by: Johan Baaij <johanbaaij@gmail.com>
Co-authored-by: Brady <37232811+BClark88@users.noreply.github.com>
* Update outdated descriptions and links (#358)
* Update reflection.md (#361)
Code examples for chan and func are incorrect
* Update select.md (#371)
Hi all,
I've been following this repo to help teach myself go and it's been a great help.
I noticed on line 399 the first argument in t.Run doesn't match the assertion. Raising this PR for your consideration as to whether you think this wording fits better or not.
* specifying what files need to be created
Co-authored-by: 森 優太 mori <59682979+uta-mori@users.noreply.github.com>
Co-authored-by: Johan Baaij <johanbaaij@gmail.com>
Co-authored-by: Brady <37232811+BClark88@users.noreply.github.com>
* Improve http-server docs clarity
- how type http.Handler is implemented
- usage of http.HandlerFunc
Signed-off-by: nicnicknicky <5416460+nicnicknicky@users.noreply.github.com>
* Add documentation to include mutex addition
Signed-off-by: nicnicknicky <5416460+nicnicknicky@users.noreply.github.com>
