archive-gh-me/jsdoc
1
0
Fork 0
mirror of https://github.com/jsdoc/jsdoc.git synced 2025-12-08 19:46:11 +00:00
Code Issues Projects Releases Wiki Activity

add fast path to hasAncestor

Browse Source
This commit is contained in:
Jeff Williams 2015-01-16 09:02:13 -08:00
parent 5b4e2c51f7
commit db9a570e2d
2 changed files with 11 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
lib/jsdoc/name.js
View File

@ -217,6 +217,11 @@ exports.hasAncestor = function(parent, child) {
return hasAncestor;
}
// fast path for obvious non-ancestors
if (child.indexOf(parent) !== 0) {
return hasAncestor;
}
do {
memberof = exports.shorten(memberof).memberof;

6
test/specs/jsdoc/name.js
View File

@ -293,6 +293,12 @@ describe('jsdoc/name', function() {
expect(hasAncestor).toBe(true);
});
it('should correctly identify when a non-ancestor is passed in', function() {
var hasAncestor = jsdoc.name.hasAncestor('module:foo', 'foo');
expect(hasAncestor).toBe(false);
});
it('should not say that a longname is its own ancestor', function() {
var hasAncestor = jsdoc.name.hasAncestor('module:foo', 'module:foo');