From 9896096b883d4f839dfd0af0b95557942e4636d2 Mon Sep 17 00:00:00 2001 From: Jannon Date: Wed, 21 Mar 2012 00:02:44 -0700 Subject: [PATCH] Test and fix for #84 --- rhino_modules/jsdoc/tag/validator.js | 4 ++-- test/cases/ignoretag2.js | 6 ++++++ test/t/cases/ignoretag.js | 8 ++++++++ 3 files changed, 16 insertions(+), 2 deletions(-) create mode 100644 test/cases/ignoretag2.js diff --git a/rhino_modules/jsdoc/tag/validator.js b/rhino_modules/jsdoc/tag/validator.js index e4f77c6d..cc02568d 100644 --- a/rhino_modules/jsdoc/tag/validator.js +++ b/rhino_modules/jsdoc/tag/validator.js @@ -43,9 +43,9 @@ function TagValueRequiredError(tagName, meta) { } TagValueRequiredError.prototype = Error.prototype; -function TagValueNotPermittedError(tagName, message, meta) { +function TagValueNotPermittedError(tagName, meta) { this.name = 'TagValueNotPermittedError'; - this.message = 'The @' + tagName + ' tag does not permit a value: "' + message + '". File: ' + meta.filename + ', Line: ' + meta.lineno + '\n' + meta.comment; + this.message = 'The @' + tagName + ' tag does not permit a value. File: ' + meta.filename + ', Line: ' + meta.lineno + '\n' + meta.comment; } TagValueNotPermittedError.prototype = Error.prototype; diff --git a/test/cases/ignoretag2.js b/test/cases/ignoretag2.js new file mode 100644 index 00000000..43db1b49 --- /dev/null +++ b/test/cases/ignoretag2.js @@ -0,0 +1,6 @@ +/** + @ignore value that shouldn't be here +*/ +function foo(x) { + +} diff --git a/test/t/cases/ignoretag.js b/test/t/cases/ignoretag.js index 32e1b9d0..f51ebfa2 100644 --- a/test/t/cases/ignoretag.js +++ b/test/t/cases/ignoretag.js @@ -6,4 +6,12 @@ assert.equal(foo.ignore, true); }); + try { + docSet = testhelpers.getDocSetFromFile('test/cases/ignoretag2.js'); + foo = docSet.getByLongname('foo')[0]; + } catch (e) { + test('When a symbol has an @ignore tag with a value an error is thrown', function() { + assert.equal(e.name, 'TagValueNotPermittedError'); + }); + } })(); \ No newline at end of file