From a0553bb9423bea3ae74c7ccb6d285d451e846b71 Mon Sep 17 00:00:00 2001 From: Jeff Williams Date: Tue, 3 Dec 2013 11:49:22 -0800 Subject: [PATCH] replace `undefined` with `null` instead of the string "undefined" --- lib/jsdoc/util/dumper.js | 2 +- test/specs/jsdoc/util/dumper.js | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/jsdoc/util/dumper.js b/lib/jsdoc/util/dumper.js index 2fce415b..1699b9c6 100644 --- a/lib/jsdoc/util/dumper.js +++ b/lib/jsdoc/util/dumper.js @@ -53,7 +53,7 @@ ObjectWalker.prototype.walk = function(o) { result = ''; } else if ( o === undefined ) { - result = 'undefined'; + result = null; } else if ( Array.isArray(o) ) { result = this.checkCircularRefs(o, function(arr) { diff --git a/test/specs/jsdoc/util/dumper.js b/test/specs/jsdoc/util/dumper.js index 75df5702..e08d25c8 100644 --- a/test/specs/jsdoc/util/dumper.js +++ b/test/specs/jsdoc/util/dumper.js @@ -39,7 +39,7 @@ describe("jsdoc/util/dumper", function() { }); it("can dump undefined values", function() { - expect(common.dumper.dump(undefined)).toEqual('"undefined"'); + expect(common.dumper.dump(undefined)).toEqual('null'); }); it("can dump regex values", function() { @@ -86,7 +86,7 @@ describe("jsdoc/util/dumper", function() { var actual = common.dumper.dump( [undefined, null, new Foo(), 1, true, 'hello\n"world', new Error('oops'), /foo/gi, new Date('December 26, 2010 GMT'), {f: function myFunc(){}, o: {a:1}}] ), - expected = '[\n "undefined",\n null,\n {},\n 1,\n true,\n "hello\\n\\"world",\n {\n "message": "oops"\n },\n "",\n "",\n {\n "f": "",\n "o": {\n "a": 1\n }\n }\n]'; + expected = '[\n null,\n null,\n {},\n 1,\n true,\n "hello\\n\\"world",\n {\n "message": "oops"\n },\n "",\n "",\n {\n "f": "",\n "o": {\n "a": 1\n }\n }\n]'; expect(actual).toEqual(expected); });