From 7dfefd791085d434c39404baf2f763f6987264a7 Mon Sep 17 00:00:00 2001
From: Jeff Williams <jeffrey.l.williams@gmail.com>
Date: Sat, 12 Apr 2014 20:13:57 -0700
Subject: [PATCH] simplify logic

---
 lib/jsdoc/tag/validator.js | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)

diff --git a/lib/jsdoc/tag/validator.js b/lib/jsdoc/tag/validator.js
index 2a2d511d..8af81860 100644
--- a/lib/jsdoc/tag/validator.js
+++ b/lib/jsdoc/tag/validator.js
@@ -28,14 +28,10 @@ exports.validate = function(tag, tagDef, meta) {
     if (!tagDef && !env.conf.tags.allowUnknownTags) {
         logger.error( buildMessage(tag.title, meta, 'is not a known tag') );
     }
-    else if (!tag.text) {
-        if (tagDef.mustHaveValue) {
-            logger.error( buildMessage(tag.title, meta, 'requires a value') );
-        }
+    else if (!tag.text && tagDef.mustHaveValue) {
+        logger.error( buildMessage(tag.title, meta, 'requires a value') );
     }
-    else {
-        if (tagDef.mustNotHaveValue) {
-            logger.error( buildMessage(tag.title, meta, 'does not permit a value') );
-        }
+    else if (tag.text && tagDef.mustNotHaveValue) {
+        logger.error( buildMessage(tag.title, meta, 'does not permit a value') );
     }
 };