archive-gh-me/jsbin
1
0
Fork 0
mirror of https://github.com/jsbin/jsbin.git synced 2026-02-01 16:46:05 +00:00
Code Issues Projects Releases Wiki Activity

Add <base> to rendered frame.

Browse Source 
This is an important change, because we're seeing /a lot/ of bins being created that contain a lot of images, and when they're using relative urls (or just placeholder text like "xxx") the images request jsbin.com, _with each keystroke_.

The knock on effect is that XHR requests to jsbin (for joining jsbins together) will fail if they're using relative urls.

I'd like to get feedback on the impact of this change, because it'll alleviate a lot of unnecessary pressure from our servers.
This commit is contained in:
Remy Sharp 2014-08-07 21:09:59 +01:00
parent db4a19e217
commit 6cfcf09b17
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
public/js/runner/processor.js
View File

@ -74,6 +74,11 @@ var processor = (function () {
source = doctypeObj.tail;
combinedSource.push(doctype);
// this ensures that requests are bounced away from
// jsbin when they're relative. They shouldn't be
// hitting jsbin directly for broken images, etc.
combinedSource.push('<base href="//null.jsbin.com/">');
// Kill the blocking functions
// IE requires that this is done in the script, rather than off the window
// object outside of the doc.write.