mirror of
https://github.com/jerryscript-project/jerryscript.git
synced 2025-12-15 16:29:21 +00:00
09d8793e30
Added new test cases to improve branch coverage in Array.prototype routines. The following script is made for testing branch coverage with all the test suites (--jerry-test-suite --test262 --unittests --jerry-tests), or with only one .js file. https://github.com/matedabis/jerryscript/blob/gcov_coverage_tester/tests/gcov-tests/gcovtester.py While measuring the branch coverage we dont count JERRY_ASSERT s. The results are measured by running all the test scripts, with the modifications in the PRs. Branch coverage including pando-project#2682 and pando-project#2674: -before: 399 / 476 -after: 472 / 476 There are 28 functions in ecma-builtin-array-prototype.c, we hit 14 from them. The other 14 functions are either already covered, or we could not improve the coverage of it. More information about the coverage improvement and the branches not reached: https://gist.github.com/matedabis/d7b9fc0690aa2f4be6aa160fdf482e0e While improving the coverage we found an unnecessary condition check, which can not be false in any cases. Co-authored-by: Csaba Repasi repasics@inf.u-szeged.hu JerryScript-DCO-1.0-Signed-off-by: Csaba Repasi repasics@inf.u-szeged.hu JerryScript-DCO-1.0-Signed-off-by: Mate Dabis mdabis@inf.u-szeged.hu
90 lines
2.4 KiB
JavaScript
90 lines
2.4 KiB
JavaScript
// Copyright JS Foundation and other contributors, http://js.foundation
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
assert ([].join() === "");
|
|
assert ([1].join() === "1");
|
|
assert ([1, 2].join() === "1,2");
|
|
|
|
|
|
assert ([].join('--') === "");
|
|
assert ([1].join("--") === "1");
|
|
assert ([1, 2].join('--') === "1--2");
|
|
|
|
assert ([1,2,3].join({toString: function() { return "--"; }}) === "1--2--3");
|
|
|
|
|
|
// Join should use 'length' to as the number of elements int the array.
|
|
var lst = [1,2,3,4];
|
|
lst.length = 3;
|
|
assert (lst.join() === [1,2,3].join());
|
|
|
|
// Checking behavior when unable to get length.
|
|
var obj = {};
|
|
Object.defineProperty(obj, 'length', { 'get' : function () {throw new ReferenceError ("foo"); } });
|
|
obj.join = Array.prototype.join;
|
|
|
|
try {
|
|
obj.join();
|
|
// Should not be reached.
|
|
assert (false);
|
|
} catch (e) {
|
|
assert (e.message === "foo");
|
|
assert (e instanceof ReferenceError);
|
|
}
|
|
|
|
// Check join argument fail.
|
|
try {
|
|
[1,2,3].join({toString: function() { throw new ReferenceError ("foo"); }});
|
|
// Should not be reached.
|
|
assert (false);
|
|
} catch (e) {
|
|
assert (e.message === "foo");
|
|
assert (e instanceof ReferenceError);
|
|
}
|
|
|
|
// Check single join element fail.
|
|
try {
|
|
[1, 2, {toString: function() { throw new ReferenceError ("foo"); }}, 4].join();
|
|
// Should not be reached.
|
|
assert (false);
|
|
} catch (e) {
|
|
assert (e.message === "foo");
|
|
assert (e instanceof ReferenceError);
|
|
}
|
|
|
|
// Check join on different object.
|
|
var obj_2 = {};
|
|
obj_2.length = 3;
|
|
obj_2[0] = 1;
|
|
obj_2[1] = 2;
|
|
obj_2[2] = 3;
|
|
obj_2[3] = 4;
|
|
|
|
obj_2.join = Array.prototype.join;
|
|
|
|
assert (obj_2.join() === "1,2,3");
|
|
|
|
/* ES v5.1 15.4.4.5.7.
|
|
Checking behavior when an element throws error */
|
|
try {
|
|
var f = function () { throw new TypeError("ooo");};
|
|
var arr = [0, 1, 2, 3];
|
|
Object.defineProperty(arr, '0', { 'get' : f });
|
|
Array.prototype.join.call(arr);
|
|
assert(false);
|
|
} catch (e) {
|
|
assert(e instanceof TypeError);
|
|
assert(e.message == "ooo");
|
|
}
|