From f8dd54abb64f9520383c09478f3b74cd450365d4 Mon Sep 17 00:00:00 2001 From: Tilmann Scheller Date: Thu, 9 Mar 2017 13:41:26 +0100 Subject: [PATCH] Fix old-style function definitions and enable warning. (#1651) Function definitions with no parameters should always use the void keyword to allow the compiler to catch invalid calls of those functions at compile time. Enable -Wold-style-definition to catch this early in the future. Fixes #1649. JerryScript-DCO-1.0-Signed-off-by: Tilmann Scheller t.scheller@samsung.com --- CMakeLists.txt | 2 +- docs/05.PORT-API.md | 2 +- jerry-core/debugger/jerry-debugger-ws.c | 2 +- jerry-core/jmem/jmem-allocator.c | 2 +- jerry-core/jmem/jmem-poolman.c | 2 +- jerry-core/parser/regexp/re-compiler.c | 2 +- targets/curie_bsp/source/curie-bsp-port.c | 2 +- targets/default/jerry-port-default-date.c | 2 +- targets/default/jerry-port-default-fatal.c | 2 +- targets/mbed/source/port/jerry_port.c | 2 +- targets/mbedos5/source/jerry_port_mbed.c | 2 +- targets/nuttx-stm32f4/jerry_main.c | 2 +- targets/zephyr/src/jerry-port.c | 2 +- 13 files changed, 13 insertions(+), 13 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index a8353740c..77cf992ac 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -179,7 +179,7 @@ jerry_add_compile_flags(-fno-stack-protector) endif() if (USING_GCC OR USING_CLANG) - jerry_add_compile_warnings(all extra format-nonliteral init-self conversion sign-conversion format-security missing-declarations shadow strict-prototypes undef) + jerry_add_compile_warnings(all extra format-nonliteral init-self conversion sign-conversion format-security missing-declarations shadow strict-prototypes undef old-style-definition) jerry_add_compile_flags(-Wno-stack-protector -Wno-attributes) endif() diff --git a/docs/05.PORT-API.md b/docs/05.PORT-API.md index adaeef8f6..fe49f0c3f 100644 --- a/docs/05.PORT-API.md +++ b/docs/05.PORT-API.md @@ -196,7 +196,7 @@ bool jerry_port_get_time_zone (jerry_time_zone_t *tz_p) /** * Default implementation of jerry_port_get_current_time. */ -double jerry_port_get_current_time () +double jerry_port_get_current_time (void) { struct timeval tv; diff --git a/jerry-core/debugger/jerry-debugger-ws.c b/jerry-core/debugger/jerry-debugger-ws.c index 8e9a4a37d..ba5bda991 100644 --- a/jerry-core/debugger/jerry-debugger-ws.c +++ b/jerry-core/debugger/jerry-debugger-ws.c @@ -311,7 +311,7 @@ jerry_process_handshake (int client_socket, /**< client socket */ * false - otherwise */ bool -jerry_debugger_accept_connection () +jerry_debugger_accept_connection (void) { int server_socket; struct sockaddr_in addr; diff --git a/jerry-core/jmem/jmem-allocator.c b/jerry-core/jmem/jmem-allocator.c index cb9806f37..f79d649d9 100644 --- a/jerry-core/jmem/jmem-allocator.c +++ b/jerry-core/jmem/jmem-allocator.c @@ -37,7 +37,7 @@ jmem_init (void) * Finalize memory allocators. */ void -jmem_finalize () +jmem_finalize (void) { jmem_pools_finalize (); diff --git a/jerry-core/jmem/jmem-poolman.c b/jerry-core/jmem/jmem-poolman.c index 4ba0c4936..1710696d2 100644 --- a/jerry-core/jmem/jmem-poolman.c +++ b/jerry-core/jmem/jmem-poolman.c @@ -191,7 +191,7 @@ jmem_pools_free (void *chunk_p, /**< pointer to the chunk */ * Collect empty pool chunks */ void -jmem_pools_collect_empty () +jmem_pools_collect_empty (void) { jmem_pools_chunk_t *chunk_p = JERRY_CONTEXT (jmem_free_8_byte_chunk_p); JERRY_CONTEXT (jmem_free_8_byte_chunk_p) = NULL; diff --git a/jerry-core/parser/regexp/re-compiler.c b/jerry-core/parser/regexp/re-compiler.c index 780f8e95b..cae945d71 100644 --- a/jerry-core/parser/regexp/re-compiler.c +++ b/jerry-core/parser/regexp/re-compiler.c @@ -488,7 +488,7 @@ re_find_bytecode_in_cache (ecma_string_t *pattern_str_p, /**< pattern string */ * Run gerbage collection in RegExp cache */ void -re_cache_gc_run () +re_cache_gc_run (void) { for (uint32_t i = 0u; i < RE_CACHE_SIZE; i++) { diff --git a/targets/curie_bsp/source/curie-bsp-port.c b/targets/curie_bsp/source/curie-bsp-port.c index 4359b06bd..3719d201e 100644 --- a/targets/curie_bsp/source/curie-bsp-port.c +++ b/targets/curie_bsp/source/curie-bsp-port.c @@ -84,7 +84,7 @@ bool jerry_port_get_time_zone (jerry_time_zone_t *tz_p) /** * Curie BSP implementation of jerry_port_get_current_time. */ -double jerry_port_get_current_time () +double jerry_port_get_current_time (void) { uint32_t uptime_ms = get_uptime_ms (); uint32_t epoch_time = uptime_to_epoch (uptime_ms); diff --git a/targets/default/jerry-port-default-date.c b/targets/default/jerry-port-default-date.c index 979337783..72b785ab2 100644 --- a/targets/default/jerry-port-default-date.c +++ b/targets/default/jerry-port-default-date.c @@ -50,7 +50,7 @@ bool jerry_port_get_time_zone (jerry_time_zone_t *tz_p) /** * Default implementation of jerry_port_get_current_time. */ -double jerry_port_get_current_time () +double jerry_port_get_current_time (void) { #ifdef __GNUC__ struct timeval tv; diff --git a/targets/default/jerry-port-default-fatal.c b/targets/default/jerry-port-default-fatal.c index a93aaf7eb..865a32980 100644 --- a/targets/default/jerry-port-default-fatal.c +++ b/targets/default/jerry-port-default-fatal.c @@ -36,7 +36,7 @@ void jerry_port_default_set_abort_on_fail (bool flag) /**< new value of 'abort o * @return true - if 'abort on fail' flag is set, * false - otherwise. */ -bool jerry_port_default_is_abort_on_fail () +bool jerry_port_default_is_abort_on_fail (void) { return abort_on_fail; } /* jerry_port_default_is_abort_on_fail */ diff --git a/targets/mbed/source/port/jerry_port.c b/targets/mbed/source/port/jerry_port.c index 8efa03bfb..f37830c3d 100644 --- a/targets/mbed/source/port/jerry_port.c +++ b/targets/mbed/source/port/jerry_port.c @@ -79,7 +79,7 @@ jerry_port_get_time_zone (jerry_time_zone_t *tz_p) /**< timezone pointer */ * @return current timer's counter value in microseconds */ double -jerry_port_get_current_time () +jerry_port_get_current_time (void) { return (double) us_ticker_read (); } /* jerry_port_get_current_time */ diff --git a/targets/mbedos5/source/jerry_port_mbed.c b/targets/mbedos5/source/jerry_port_mbed.c index e8267610b..58289af9e 100644 --- a/targets/mbedos5/source/jerry_port_mbed.c +++ b/targets/mbedos5/source/jerry_port_mbed.c @@ -93,7 +93,7 @@ jerry_port_get_time_zone (jerry_time_zone_t *tz_p) /**< timezone pointer */ * @return current timer's counter value in microseconds */ double -jerry_port_get_current_time () +jerry_port_get_current_time (void) { return (double) us_ticker_read (); } /* jerry_port_get_current_time */ diff --git a/targets/nuttx-stm32f4/jerry_main.c b/targets/nuttx-stm32f4/jerry_main.c index d9a029425..b7e32c4ab 100644 --- a/targets/nuttx-stm32f4/jerry_main.c +++ b/targets/nuttx-stm32f4/jerry_main.c @@ -304,7 +304,7 @@ jerry_port_get_time_zone (jerry_time_zone_t *tz_p) * @return 0 */ double -jerry_port_get_current_time () +jerry_port_get_current_time (void) { return 0; } /* jerry_port_get_current_time */ diff --git a/targets/zephyr/src/jerry-port.c b/targets/zephyr/src/jerry-port.c index 6abe1a035..bba6a6cd1 100644 --- a/targets/zephyr/src/jerry-port.c +++ b/targets/zephyr/src/jerry-port.c @@ -65,7 +65,7 @@ void jerry_port_fatal (jerry_fatal_code_t code) * @return current timer's counter value in milliseconds */ double -jerry_port_get_current_time () +jerry_port_get_current_time (void) { int64_t ms = k_uptime_get(); return (double) ms;