archive-gh-me/jerryscript
1
0
Fork 0
mirror of https://github.com/jerryscript-project/jerryscript.git synced 2025-12-15 16:29:21 +00:00
Code Issues Projects Releases Wiki Activity

Correctly set the define property flags during [[Set] in case of Proxy (#4178)

Browse Source 
JerryScript-DCO-1.0-Signed-off-by: Peter Gal pgal.usz@partner.samsung.com
This commit is contained in:
Péter Gál 2020-09-02 17:34:15 +02:00 committed by GitHub
parent 074945dafa
commit f03bf9074f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 21 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
jerry-core/ecma/operations/ecma-objects.c
View File

@ -1083,7 +1083,14 @@ ecma_op_object_put_apply_receiver (ecma_value_t receiver, /**< receiver */
if (ECMA_OBJECT_IS_PROXY (receiver_obj_p))
{
ecma_property_descriptor_t desc;
desc.flags = ECMA_NAME_DATA_PROPERTY_DESCRIPTOR_BITS;
/* Based on: ES6 9.1.9 [[Set]] 4.d.i. / ES11 9.1.9.2 OrdinarySetWithOwnDescriptor 2.c.i. */
desc.flags = (ECMA_PROP_IS_CONFIGURABLE
| ECMA_PROP_IS_CONFIGURABLE_DEFINED
| ECMA_PROP_IS_ENUMERABLE
| ECMA_PROP_IS_ENUMERABLE_DEFINED
| ECMA_PROP_IS_WRITABLE
| ECMA_PROP_IS_WRITABLE_DEFINED
| ECMA_PROP_IS_VALUE_DEFINED);
desc.value = value;
return ecma_proxy_object_define_own_property (receiver_obj_p, property_name_p, &desc);
}

13
tests/jerry/es.next/proxy_set.js
View File

@ -138,3 +138,16 @@ try {
} catch (e) {
assert(e instanceof TypeError);
}
/* Setting a new property should be configurable, enumerable, and writable by default
* over a proxy.
*/
var setPropProxy = new Proxy({}, {});
setPropProxy["alma"] = 3;
var desc = Object.getOwnPropertyDescriptor(setPropProxy, "alma");
assert(desc.writable === true);
assert(desc.enumerable === true);
assert(desc.configurable === true);
assert(desc.value === 3);

3
tests/test262-esnext-excludelist.xml
View File

@ -822,7 +822,6 @@
<test id="built-ins/Object/prototype/toString/symbol-tag-non-str-builtin.js"><reason></reason></test>
<test id="built-ins/Object/prototype/toString/symbol-tag-non-str-proxy-function.js"><reason></reason></test>
<test id="built-ins/Object/subclass-object-arg.js"><reason></reason></test>
<test id="built-ins/Object/values/order-after-define-property.js"><reason></reason></test>
<test id="built-ins/Promise/all/invoke-resolve-get-error.js"><reason></reason></test>
<test id="built-ins/Promise/all/invoke-resolve-get-once-multiple-calls.js"><reason></reason></test>
<test id="built-ins/Promise/all/invoke-resolve-get-once-no-calls.js"><reason></reason></test>
@ -995,8 +994,6 @@
<test id="built-ins/Proxy/revocable/target-is-revoked-function-proxy.js"><reason></reason></test>
<test id="built-ins/Proxy/revocable/target-is-revoked-proxy.js"><reason></reason></test>
<test id="built-ins/Proxy/set/call-parameters-prototype-index.js"><reason></reason></test>
<test id="built-ins/Proxy/set/trap-is-missing-receiver-multiple-calls-index.js"><reason></reason></test>
<test id="built-ins/Proxy/set/trap-is-missing-receiver-multiple-calls.js"><reason></reason></test>
<test id="built-ins/Proxy/set/trap-is-missing-target-is-proxy.js"><reason></reason></test>
<test id="built-ins/Proxy/set/trap-is-not-callable-realm.js"><reason></reason></test>
<test id="built-ins/Proxy/set/trap-is-null-target-is-proxy.js"><reason></reason></test>