archive-gh-me/jerryscript
1
0
Fork 0
mirror of https://github.com/jerryscript-project/jerryscript.git synced 2025-12-15 16:29:21 +00:00
Code Issues Projects Releases Wiki Activity

Fix super property reference parsing (#2672)

Browse Source 
`PARSER_CLASS_SUPER_PROP_REFERENCE` flag should be applied for only binary lvalue tokens.
This patch fixed #2671.

JerryScript-DCO-1.0-Signed-off-by: Robert Fancsik frobert@inf.u-szeged.hu
This commit is contained in:
Robert Fancsik 2019-01-08 09:33:26 +01:00 committed by Zoltan Herczeg
parent 7b48be81c3
commit ef2c3b46d7
2 changed files with 50 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
jerry-core/parser/js/js-parser-expr.c
View File

@ -1409,7 +1409,7 @@ parser_parse_unary_expression (parser_context_t *context_p, /**< context */
|| lexer_check_next_character (context_p, LIT_CHAR_LEFT_SQUARE))
&& context_p->status_flags & (PARSER_CLASS_HAS_SUPER | PARSER_IS_ARROW_FUNCTION))
{
if (!LEXER_IS_BINARY_OP_TOKEN (context_p->stack_top_uint8))
if (!LEXER_IS_BINARY_LVALUE_TOKEN (context_p->stack_top_uint8))
{
context_p->status_flags |= PARSER_CLASS_SUPER_PROP_REFERENCE;
}

49
tests/jerry/es2015/regression-test-issue-2671.js Normal file
View File

@ -0,0 +1,49 @@
// Copyright JS Foundation and other contributors, http://js.foundation
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
class Shape {
constructor (id,x,y) {
this.id = id;
this.x = x;
this.y = y;
}
toString () {
return "Shape(" + this.id + ")"
}
}
class Rectangle extends Shape {
constructor (id, x, y, width, height) {
super (id, x, y);
}
toString () {
return "Rectangle > " + super.toString ();
}
}
class Circle extends Shape {
constructor (id, x, y, radius) {
super (id, x, y);
}
toString () {
return "Circle > " + super.toString ();
}
}
var shape = new Shape (0, 0, 0);
var rec = new Rectangle (1, 0, 0, 4, 4);
var circ = new Circle (2, 0, 0, 4);
assert (Object.keys (shape).toString () === "id,x,y");
assert (rec.id === 1);
assert (circ.id === 2);
assert (rec.toString () === "Rectangle > Shape(1)");
assert (circ.toString () === "Circle > Shape(2)");