From e227634b45e05c97d43ac4fc3e34d187b0953777 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Csaba=20Osztrogon=C3=A1c?= Date: Thu, 1 Oct 2020 16:34:09 +0200 Subject: [PATCH] Make Date.UTC to conform to the latest ES11 spec (#4250) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Date.UTC should work with only one argument too. JerryScript-DCO-1.0-Signed-off-by: Csaba Osztrogonác csaba.osztrogonac@h-lab.eu --- .../ecma/builtin-objects/ecma-builtin-date.c | 8 +++++++- tests/jerry/date-utc.js | 3 --- tests/jerry/es5.1/date-utc.js | 16 ++++++++++++++++ tests/test262-esnext-excludelist.xml | 1 - 4 files changed, 23 insertions(+), 5 deletions(-) create mode 100644 tests/jerry/es5.1/date-utc.js diff --git a/jerry-core/ecma/builtin-objects/ecma-builtin-date.c b/jerry-core/ecma/builtin-objects/ecma-builtin-date.c index 695a395d2..6a1285e55 100644 --- a/jerry-core/ecma/builtin-objects/ecma-builtin-date.c +++ b/jerry-core/ecma/builtin-objects/ecma-builtin-date.c @@ -617,7 +617,13 @@ ecma_builtin_date_utc (ecma_value_t this_arg, /**< this argument */ { JERRY_UNUSED (this_arg); - if (args_number < 2) +#if ENABLED (JERRY_ESNEXT) + const uint32_t required_args_number = 1; +#else /* !ENABLED (JERRY_ESNEXT) */ + const uint32_t required_args_number = 2; +#endif /* ENABLED (JERRY_ESNEXT) */ + + if (args_number < required_args_number) { /* Note: * When the UTC function is called with fewer than two arguments, diff --git a/tests/jerry/date-utc.js b/tests/jerry/date-utc.js index 4b6e3d38f..fe272f8f8 100644 --- a/tests/jerry/date-utc.js +++ b/tests/jerry/date-utc.js @@ -20,9 +20,6 @@ assert (isNaN(d)); d = Date.UTC({}); assert (isNaN(d)); -d = Date.UTC(2015); -assert (isNaN(d)); - d = Date.UTC(2000 + 15, 0); assert (d == 1420070400000); diff --git a/tests/jerry/es5.1/date-utc.js b/tests/jerry/es5.1/date-utc.js new file mode 100644 index 000000000..4ade1f750 --- /dev/null +++ b/tests/jerry/es5.1/date-utc.js @@ -0,0 +1,16 @@ +// Copyright JS Foundation and other contributors, http://js.foundation +// +// Licensed under the Apache License, Version 2.0 (the "License"); +// you may not use this file except in compliance with the License. +// You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. + +var d = Date.UTC(2015); +assert (isNaN(d)); diff --git a/tests/test262-esnext-excludelist.xml b/tests/test262-esnext-excludelist.xml index 5e5942066..50c8fb6d2 100644 --- a/tests/test262-esnext-excludelist.xml +++ b/tests/test262-esnext-excludelist.xml @@ -694,7 +694,6 @@ -