From b2d34724d4b02fd892310040bddf4432d7c20ed3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?D=C3=A1niel=20B=C3=A1tyai?= Date: Mon, 25 Nov 2019 11:49:04 +0100 Subject: [PATCH] Fix Reflect.getPrototypeOf for primitive arguments (#3354) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Fixes #3349. JerryScript-DCO-1.0-Signed-off-by: Dániel Bátyai dbatyai@inf.u-szeged.hu --- .../ecma/builtin-objects/ecma-builtin-reflect.c | 3 +-- tests/jerry/es2015/reflect-getPrototypeOf.js | 14 ++++++++++++++ 2 files changed, 15 insertions(+), 2 deletions(-) diff --git a/jerry-core/ecma/builtin-objects/ecma-builtin-reflect.c b/jerry-core/ecma/builtin-objects/ecma-builtin-reflect.c index f78f59f38..578bb253a 100644 --- a/jerry-core/ecma/builtin-objects/ecma-builtin-reflect.c +++ b/jerry-core/ecma/builtin-objects/ecma-builtin-reflect.c @@ -77,8 +77,7 @@ ecma_builtin_reflect_dispatch_routine (uint16_t builtin_routine_id, /**< built-i JERRY_UNUSED (this_arg); JERRY_UNUSED (arguments_number); - if (!ecma_is_value_object (arguments_list[0]) - && builtin_routine_id > ECMA_REFLECT_OBJECT_SET_PROTOTYPE_OF_UL) + if (!ecma_is_value_object (arguments_list[0])) { return ecma_raise_type_error (ECMA_ERR_MSG ("Argument is not an Object.")); } diff --git a/tests/jerry/es2015/reflect-getPrototypeOf.js b/tests/jerry/es2015/reflect-getPrototypeOf.js index a0a59990d..140bfce96 100644 --- a/tests/jerry/es2015/reflect-getPrototypeOf.js +++ b/tests/jerry/es2015/reflect-getPrototypeOf.js @@ -15,3 +15,17 @@ assert (Reflect['getPrototypeOf']({}) === Object.prototype); assert (Reflect['getPrototypeOf'](Object.create(null)) === null); assert (Reflect['getPrototypeOf'](Object.prototype) === null); + +try { + Reflect.getPrototypeOf(); + assert (false); +} catch (e) { + assert (e instanceof TypeError); +} + +try { + Reflect.getPrototypeOf("str"); + assert (false); +} catch (e) { + assert (e instanceof TypeError); +}