From b27f40303b6f2efcb4de7761c016224ce30388f8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?P=C3=A9ter=20G=C3=A1l?= Date: Thu, 30 Jul 2020 16:24:26 +0200 Subject: [PATCH] Fix TypeError name property value (#4086) The TypeError.name incorrectly returned the "SyntaxError" value. JerryScript-DCO-1.0-Signed-off-by: Peter Gal pgal.usz@partner.samsung.com --- .../ecma-builtin-typeerror.inc.h | 2 +- tests/jerry/es.next/error-names.js | 31 +++++++++++++++++++ 2 files changed, 32 insertions(+), 1 deletion(-) create mode 100644 tests/jerry/es.next/error-names.js diff --git a/jerry-core/ecma/builtin-objects/ecma-builtin-typeerror.inc.h b/jerry-core/ecma/builtin-objects/ecma-builtin-typeerror.inc.h index 828428bb3..528accaa8 100644 --- a/jerry-core/ecma/builtin-objects/ecma-builtin-typeerror.inc.h +++ b/jerry-core/ecma/builtin-objects/ecma-builtin-typeerror.inc.h @@ -38,7 +38,7 @@ OBJECT_VALUE (LIT_MAGIC_STRING_PROTOTYPE, #if ENABLED (JERRY_ESNEXT) STRING_VALUE (LIT_MAGIC_STRING_NAME, - LIT_MAGIC_STRING_SYNTAX_ERROR_UL, + LIT_MAGIC_STRING_TYPE_ERROR_UL, ECMA_PROPERTY_FLAG_CONFIGURABLE) #endif /* ENABLED (JERRY_ESNEXT) */ diff --git a/tests/jerry/es.next/error-names.js b/tests/jerry/es.next/error-names.js new file mode 100644 index 000000000..05232dd97 --- /dev/null +++ b/tests/jerry/es.next/error-names.js @@ -0,0 +1,31 @@ +/* Copyright JS Foundation and other contributors, http://js.foundation + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +var items = [ + [TypeError, "TypeError"], + [SyntaxError, "SyntaxError"], + [URIError, "URIError"], + [EvalError, "EvalError"], + [RangeError, "RangeError"], + [ReferenceError, "ReferenceError"], +]; + +for (var idx = 0; idx < items.length; idx++) { + var type = items[idx][0]; + var expected_name = items[idx][1]; + assert (type.name === expected_name); + + assert ((new type).name === expected_name); +}