archive-gh-me/jerryscript
1
0
Fork 0
mirror of https://github.com/jerryscript-project/jerryscript.git synced 2025-12-15 16:29:21 +00:00
Code Issues Projects Releases Wiki Activity

Fix value release in ecma_builtin_array_prototype_object_copy_within (#3583)

Browse Source 
Fixes #3580

JerryScript-DCO-1.0-Signed-off-by: Adam Szilagyi aszilagy@inf.u-szeged.hu
This commit is contained in:
Szilagyi Adam 2020-03-02 10:28:02 +01:00 committed by GitHub
parent 4e136c8973
commit a6acf2d417
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 23 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
jerry-core/ecma/builtin-objects/ecma-builtin-array-prototype.c
View File

@ -2441,8 +2441,11 @@ ecma_builtin_array_prototype_object_copy_within (const ecma_value_t args[], /**<
for (; count > 0; count--)
{
ecma_value_t copy_value = ecma_copy_value_if_not_object (buffer_p[start]);
ecma_free_value_if_not_object (buffer_p[target]);
buffer_p[target] = ecma_copy_value_if_not_object (buffer_p[start]);
buffer_p[target] = copy_value;
if (forward)
{

19
tests/jerry/es2015/regression-test-issue-3580.js Normal file
View File

@ -0,0 +1,19 @@
// Copyright JS Foundation and other contributors, http://js.foundation
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
var func = function(val, idx) {
return val + idx
};
String([0, "X"].map(func).copyWithin([]));