From 9a8160176cb0ddf736fbf757030b7cbc550110cc Mon Sep 17 00:00:00 2001 From: Zoltan Herczeg Date: Mon, 13 Jan 2020 15:13:57 +0100 Subject: [PATCH] Nested destructuring binding patterns should inherit the PARSER_PATTERN_ARGUMENTS flag. (#3508) Fixes #3398. JerryScript-DCO-1.0-Signed-off-by: Zoltan Herczeg zherczeg.u-szeged@partner.samsung.com --- jerry-core/parser/js/js-parser-expr.c | 3 ++- .../jerry/fail/regression-test-issue-3398.js | 20 +++++++++++++++++++ 2 files changed, 22 insertions(+), 1 deletion(-) create mode 100644 tests/jerry/fail/regression-test-issue-3398.js diff --git a/jerry-core/parser/js/js-parser-expr.c b/jerry-core/parser/js/js-parser-expr.c index 3bff32949..7536263e6 100644 --- a/jerry-core/parser/js/js-parser-expr.c +++ b/jerry-core/parser/js/js-parser-expr.c @@ -2531,7 +2531,8 @@ parser_pattern_process_nested_pattern (parser_context_t *context_p, /**< context | (flags & (PARSER_PATTERN_BINDING | PARSER_PATTERN_LEXICAL | PARSER_PATTERN_LOCAL - | PARSER_PATTERN_REST_ELEMENT))); + | PARSER_PATTERN_REST_ELEMENT + | PARSER_PATTERN_ARGUMENTS))); if (context_p->next_scanner_info_p->source_p == context_p->source_p) { diff --git a/tests/jerry/fail/regression-test-issue-3398.js b/tests/jerry/fail/regression-test-issue-3398.js new file mode 100644 index 000000000..367b1f4b5 --- /dev/null +++ b/tests/jerry/fail/regression-test-issue-3398.js @@ -0,0 +1,20 @@ +// Copyright JS Foundation and other contributors, http://js.foundation +// +// Licensed under the Apache License, Version 2.0 (the "License"); +// you may not use this file except in compliance with the License. +// You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. + +function f($, [ + [b, [c] = [], {} = { + $: eval() + }] +] = [[]], c) {} +f()