From 8f39d90f7c8aa3ed78b2f552ec7bb064b9999437 Mon Sep 17 00:00:00 2001 From: Robert Fancsik Date: Wed, 16 Oct 2019 14:00:47 +0200 Subject: [PATCH] Static strings should be reference counted in debug mode (#3219) This patch helps to find out invalid reference count usage for ecma-strings. JerryScript-DCO-1.0-Signed-off-by: Robert Fancsik frobert@inf.u-szeged.hu --- jerry-core/ecma/base/ecma-helpers-string.c | 18 ++++++++++++++++-- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/jerry-core/ecma/base/ecma-helpers-string.c b/jerry-core/ecma/base/ecma-helpers-string.c index bbe419bc4..9a3c7a1ad 100644 --- a/jerry-core/ecma/base/ecma-helpers-string.c +++ b/jerry-core/ecma/base/ecma-helpers-string.c @@ -822,11 +822,18 @@ ecma_ref_ecma_string (ecma_string_t *string_p) /**< string descriptor */ { JERRY_ASSERT (string_p != NULL); - if (ECMA_IS_DIRECT_STRING (string_p) || ECMA_STRING_IS_STATIC (string_p)) + if (ECMA_IS_DIRECT_STRING (string_p)) { return; } +#ifdef JERRY_NDEBUG + if (ECMA_STRING_IS_STATIC (string_p)) + { + return; + } +#endif /* JERRY_NDEBUG */ + JERRY_ASSERT (string_p->refs_and_container >= ECMA_STRING_REF_ONE); if (JERRY_LIKELY (string_p->refs_and_container < ECMA_STRING_MAX_REF)) @@ -849,11 +856,18 @@ ecma_deref_ecma_string (ecma_string_t *string_p) /**< ecma-string */ { JERRY_ASSERT (string_p != NULL); - if (ECMA_IS_DIRECT_STRING (string_p) || ECMA_STRING_IS_STATIC (string_p)) + if (ECMA_IS_DIRECT_STRING (string_p)) { return; } +#ifdef JERRY_NDEBUG + if (ECMA_STRING_IS_STATIC (string_p)) + { + return; + } +#endif /* JERRY_NDEBUG */ + JERRY_ASSERT (string_p->refs_and_container >= ECMA_STRING_REF_ONE); /* Decrease reference counter. */