From 8eda9bc1c3683d1e498d0ed0dba38246c1c11c80 Mon Sep 17 00:00:00 2001 From: Robert Fancsik Date: Thu, 14 Nov 2019 14:46:01 +0100 Subject: [PATCH] Fix the usage of escaped identifiers in scanner_scope_find_let_declaration (#3317) This patch fixes #3313. JerryScript-DCO-1.0-Signed-off-by: Robert Fancsik frobert@inf.u-szeged.hu --- jerry-core/parser/js/js-scanner-util.c | 2 ++ tests/jerry/regression-test-issue-3313.js | 20 ++++++++++++++++++++ 2 files changed, 22 insertions(+) create mode 100644 tests/jerry/regression-test-issue-3313.js diff --git a/jerry-core/parser/js/js-scanner-util.c b/jerry-core/parser/js/js-scanner-util.c index ad36e1b23..ca31ccf15 100644 --- a/jerry-core/parser/js/js-scanner-util.c +++ b/jerry-core/parser/js/js-scanner-util.c @@ -1010,6 +1010,8 @@ scanner_scope_find_let_declaration (parser_context_t *context_p, /**< context */ { uint8_t *destination_p = (uint8_t *) scanner_malloc (context_p, literal_p->length); + lexer_convert_ident_to_utf8 (literal_p->char_p, destination_p, literal_p->length); + name_p = ecma_new_ecma_string_from_utf8 (destination_p, literal_p->length); scanner_free (destination_p, literal_p->length); } diff --git a/tests/jerry/regression-test-issue-3313.js b/tests/jerry/regression-test-issue-3313.js new file mode 100644 index 000000000..dfb0fb294 --- /dev/null +++ b/tests/jerry/regression-test-issue-3313.js @@ -0,0 +1,20 @@ +// Copyright JS Foundation and other contributors, http://js.foundation +// +// Licensed under the Apache License, Version 2.0 (the "License"); +// you may not use this file except in compliance with the License. +// You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. + +try { + eval("var" + "\u2029" + 'g\\u0065t: break get' ); + assert (false); +} catch (e) { + assert (e instanceof SyntaxError); +}