From 6fe6dab9cc4dec8ae2f1bcc86137c4775397f716 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?P=C3=A9ter=20G=C3=A1l?= Date: Mon, 25 May 2020 13:05:18 +0200 Subject: [PATCH] Fix parseFloat input string length calculation (#3782) JerryScript-DCO-1.0-Signed-off-by: Peter Gal pgal.usz@partner.samsung.com --- jerry-core/ecma/base/ecma-helpers-number.c | 2 +- tests/jerry/regression-test-issue-3778.js | 15 +++++++++++++++ 2 files changed, 16 insertions(+), 1 deletion(-) create mode 100644 tests/jerry/regression-test-issue-3778.js diff --git a/jerry-core/ecma/base/ecma-helpers-number.c b/jerry-core/ecma/base/ecma-helpers-number.c index 14a0aea7d..cd1d23613 100644 --- a/jerry-core/ecma/base/ecma-helpers-number.c +++ b/jerry-core/ecma/base/ecma-helpers-number.c @@ -941,7 +941,7 @@ ecma_number_parse_float (const lit_utf8_byte_t *string_buff, /**< routine's firs /* The input string should be at least the length of "Infinity" to be correctly processed as * the infinity value. */ - if (string_buff_size >= infinity_length + if ((str_end_p - str_curr_p) >= (int) infinity_length && memcmp (infinity_str_p, str_curr_p, infinity_length) == 0) { /* String matched Infinity. */ diff --git a/tests/jerry/regression-test-issue-3778.js b/tests/jerry/regression-test-issue-3778.js new file mode 100644 index 000000000..512eb0a13 --- /dev/null +++ b/tests/jerry/regression-test-issue-3778.js @@ -0,0 +1,15 @@ +// Copyright JS Foundation and other contributors, http://js.foundation +// +// Licensed under the Apache License, Version 2.0 (the "License"); +// you may not use this file except in compliance with the License. +// You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. + +assert (parseFloat (-0.00001) === -0.00001);