From 51efba40b47a6bc0af98860d0d760f56cdf4c604 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Csaba=20Osztrogon=C3=A1c?= Date: Fri, 29 Nov 2019 20:54:57 +0100 Subject: [PATCH] Remove dead code from ecma_date_parse_year() (#3387) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Code cleanup after #3314. Reverting already parsed '-' sign after parse fail is unnecessary, because in this case the whole date parse is failed. Additionally this dead code was incorrect too, because it didn't modify the original pointer to the string, but a local variable. JerryScript-DCO-1.0-Signed-off-by: Csaba Osztrogonác oszi@inf.u-szeged.hu --- jerry-core/ecma/builtin-objects/ecma-builtin-date.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/jerry-core/ecma/builtin-objects/ecma-builtin-date.c b/jerry-core/ecma/builtin-objects/ecma-builtin-date.c index 89f526a37..61fce54b5 100644 --- a/jerry-core/ecma/builtin-objects/ecma-builtin-date.c +++ b/jerry-core/ecma/builtin-objects/ecma-builtin-date.c @@ -133,10 +133,6 @@ ecma_date_parse_year (const lit_utf8_byte_t **str_p, /**< pointer to the cesu8 s return parsed_year; } - if (is_year_sign_negative) - { - str_p--; /* Parse failed, revert already parsed '-' sign. */ - } return ecma_number_make_nan (); } /* ecma_date_parse_year */