From 4d5757d1b1be2b3e337a67b1f84dbd865b2a99f3 Mon Sep 17 00:00:00 2001 From: Robert Fancsik Date: Tue, 28 Jul 2020 10:53:08 +0200 Subject: [PATCH] Fix argument list end validation after destructuring argument (#4070) This patch fixes #4050. JerryScript-DCO-1.0-Signed-off-by: Robert Fancsik frobert@inf.u-szeged.hu --- jerry-core/parser/js/js-parser.c | 7 ++++++ .../es.next/regression-test-issue-4050.js | 23 +++++++++++++++++++ 2 files changed, 30 insertions(+) create mode 100644 tests/jerry/es.next/regression-test-issue-4050.js diff --git a/jerry-core/parser/js/js-parser.c b/jerry-core/parser/js/js-parser.c index 59e037df0..9de28e84b 100644 --- a/jerry-core/parser/js/js-parser.c +++ b/jerry-core/parser/js/js-parser.c @@ -1877,6 +1877,13 @@ parser_parse_function_arguments (parser_context_t *context_p, /**< context */ if (context_p->token.type != LEXER_COMMA) { + if (context_p->token.type != end_type) + { + parser_error_t error = ((end_type == LEXER_RIGHT_PAREN) ? PARSER_ERR_RIGHT_PAREN_EXPECTED + : PARSER_ERR_IDENTIFIER_EXPECTED); + + parser_raise_error (context_p, error); + } break; } diff --git a/tests/jerry/es.next/regression-test-issue-4050.js b/tests/jerry/es.next/regression-test-issue-4050.js new file mode 100644 index 000000000..5f1764819 --- /dev/null +++ b/tests/jerry/es.next/regression-test-issue-4050.js @@ -0,0 +1,23 @@ +// Copyright JS Foundation and other contributors, http://js.foundation +// +// Licensed under the Apache License, Version 2.0 (the "License"); +// you may not use this file except in compliance with the License. +// You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. + +try { + eval(`function write([a] of { } + (function Test1() { + write(""); + });`); + assert(false); +} catch (e) { + assert (e instanceof SyntaxError); +}