archive-gh-me/jerryscript
1
0
Fork 0
mirror of https://github.com/jerryscript-project/jerryscript.git synced 2025-12-15 16:29:21 +00:00
Code Issues Projects Releases Wiki Activity

Add missing ecma_free_value in ecma_builtin_promise_do_all (#2604)

Browse Source 
This patch fixes #2602 and fixes #2603 as well.

JerryScript-DCO-1.0-Signed-off-by: Robert Fancsik frobert@inf.u-szeged.hu
This commit is contained in:
Robert Fancsik 2018-11-20 14:40:34 +01:00 committed by Zoltan Herczeg
parent 704eb45cb8
commit 49a0836daa
3 changed files with 34 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
jerry-core/ecma/builtin-objects/ecma-builtin-promise.c
View File

@ -478,6 +478,7 @@ ecma_builtin_promise_do_all (ecma_value_t array, /**< the array for all */
if (ECMA_IS_VALUE_ERROR (put_ret)) if (ECMA_IS_VALUE_ERROR (put_ret))
{ {
ecma_free_value (array_item);
ret = put_ret; ret = put_ret;
break; break;
} }

16
tests/jerry/es2015/regression-test-issue-2602.js Normal file
View File

@ -0,0 +1,16 @@
// Copyright JS Foundation and other contributors, http://js.foundation
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
Object.defineProperty ( Array.prototype , 0 , { set : function ( ) { throw "MyError" } } ) ;
Promise.all ( [ "2015-01-01" ] ) ;

17
tests/jerry/es2015/regression-test-issue-2603.js Normal file
View File

@ -0,0 +1,17 @@
// Copyright JS Foundation and other contributors, http://js.foundation
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
Object.defineProperty( Array.prototype, 0, { set : function ( ) { throw "MyError" } } );
Promise.all( [ .86456 ] ) ;