From 3b5224b98dcb07d513c39e4ea145395f3ed53443 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Csaba=20Osztrogon=C3=A1c?= Date: Thu, 14 Nov 2019 10:13:15 +0100 Subject: [PATCH] Fix timezone in Date.prototype.toString() (#3310) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Timezone minutes part was always 0 instead of the proper value. Additionally fixed minor typos in comments. JerryScript-DCO-1.0-Signed-off-by: Csaba Osztrogonác oszi@inf.u-szeged.hu --- jerry-core/ecma/builtin-objects/ecma-builtin-helpers-date.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/jerry-core/ecma/builtin-objects/ecma-builtin-helpers-date.c b/jerry-core/ecma/builtin-objects/ecma-builtin-helpers-date.c index 366180832..6c2740b58 100644 --- a/jerry-core/ecma/builtin-objects/ecma-builtin-helpers-date.c +++ b/jerry-core/ecma/builtin-objects/ecma-builtin-helpers-date.c @@ -696,7 +696,7 @@ ecma_date_to_string_format (ecma_number_t datetime_number, /**< datetime */ number_length = 3; break; } - case LIT_CHAR_LOWERCASE_Z: /* Time zone minutes part. */ + case LIT_CHAR_LOWERCASE_Z: /* Time zone hours part. */ { int32_t time_zone = (int32_t) ecma_date_local_time_zone_adjustment (datetime_number); @@ -716,7 +716,7 @@ ecma_date_to_string_format (ecma_number_t datetime_number, /**< datetime */ } default: { - JERRY_ASSERT (*format_p == LIT_CHAR_UPPERCASE_Z); /* Time zone seconds part. */ + JERRY_ASSERT (*format_p == LIT_CHAR_UPPERCASE_Z); /* Time zone minutes part. */ int32_t time_zone = (int32_t) ecma_date_local_time_zone_adjustment (datetime_number); @@ -725,7 +725,7 @@ ecma_date_to_string_format (ecma_number_t datetime_number, /**< datetime */ time_zone = -time_zone; } - number = time_zone % (int32_t) ECMA_DATE_MS_PER_HOUR; + number = time_zone % (int32_t) ECMA_DATE_MS_PER_HOUR / (int32_t) ECMA_DATE_MS_PER_MINUTE; number_length = 2; break; }