archive-gh-me/jerryscript
1
0
Fork 0
mirror of https://github.com/jerryscript-project/jerryscript.git synced 2025-12-15 16:29:21 +00:00
Code Issues Projects Releases Wiki Activity

Fix string dereference in ecma_op_create_dynamic_function (#3873)

Browse Source 
Fixes #3862

JerryScript-DCO-1.0-Signed-off-by: Adam Szilagyi aszilagy@inf.u-szeged.hu
This commit is contained in:
Szilagyi Adam 2020-06-08 10:23:26 +02:00 committed by GitHub
parent ba4e3a402f
commit 358101f27f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 34 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
jerry-core/ecma/builtin-objects/ecma-builtin-reflect.c
View File

@ -179,7 +179,7 @@ ecma_builtin_reflect_dispatch_routine (uint16_t builtin_routine_id, /**< built-i
ecma_object_t *target_p = ecma_get_object_from_value (arguments_list[0]);
/* 2. new_target_p is not supported for now*/
/* 2. */
ecma_object_t *new_target_p = target_p;
if (arguments_number > 2)

2
jerry-core/ecma/operations/ecma-function-object.c
View File

@ -419,6 +419,8 @@ ecma_op_create_dynamic_function (const ecma_value_t *arguments_list_p, /**< argu
if (JERRY_UNLIKELY (proto == NULL))
{
ecma_bytecode_deref (bytecode_data_p);
ecma_deref_ecma_string (arguments_str_p);
ecma_deref_ecma_string (function_body_str_p);
return ECMA_VALUE_ERROR;
}
#endif /* ENABLED (JERRY_ES2015) */

4
tests/jerry/es2015/reflect-construct.js
View File

@ -51,8 +51,8 @@ function DogClass () {
var obj1 = Reflect.construct (CatClass, args, DogClass);
assert (obj1.name === 'Cat');
// assert (!(ob1 instanceof CatClass)); This is true because new target is not supported yet
// assert (obj1 instanceof DogClass); This is false because new target is not supported yet
assert (!(obj1 instanceof CatClass));
assert (obj1 instanceof DogClass);
try {
Reflect.construct (func1, 5, 5);

29
tests/jerry/es2015/regression-test-issue-3862.js Normal file
View File

@ -0,0 +1,29 @@
// Copyright JS Foundation and other contributors, http://js.foundation
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
var target = function() {};
var handler = {
get() {
if ($);
}
};
var o = new Proxy(target, handler);
try {
Reflect.construct(Function, ['c'], o);
assert(false);
} catch (e) {
assert(e instanceof ReferenceError);
}