From 1f7606fc05f162dbba158883c9ee3a95e8cbd5e5 Mon Sep 17 00:00:00 2001 From: Akos Kiss Date: Fri, 14 Jul 2017 19:53:59 +0200 Subject: [PATCH] Improve pylint runner script (#1915) - On OSX, `find` is more picky about its arguments than on Linux and requires the start directory(-ies) to be explicitly mentioned before the expressions (a.k.a. "primaries"). However, until now, the `pylint` runner script called `find` without a start dir, which caused an error on OSX. - Until now, `find` looked for python scripts in all subdirectories of the project, causing `pylint` to check scripts under `targets/` and `tests/test262` (if `test262` was checked out). However, the files under `targets/` are less strictly controlled while `test262` is completely beyond the control of the project. This caused a lot of superfluous lint warnings. This patch makes the `pylint` runner script call `find` in the cross-platform way, and also limits the scope of the lint checks to the `tools/` and `jerry-debugger/` directories. JerryScript-DCO-1.0-Signed-off-by: Akos Kiss akiss@inf.u-szeged.hu --- tools/check-pylint.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/check-pylint.sh b/tools/check-pylint.sh index 20016c38b..8b229c7fb 100755 --- a/tools/check-pylint.sh +++ b/tools/check-pylint.sh @@ -14,5 +14,5 @@ # See the License for the specific language governing permissions and # limitations under the License. -find -name "*.py" \ +find ./tools ./jerry-debugger -name "*.py" \ | xargs pylint --rcfile=tools/pylint/pylintrc