archive-gh-me/jerryscript
1
0
Fork 0
mirror of https://github.com/jerryscript-project/jerryscript.git synced 2025-12-15 16:29:21 +00:00
Code Issues Projects Releases Wiki Activity

Variables created by eval in strict mode should ignore the properties of their parent function. (#4339)

Browse Source 
Fixes #4018

JerryScript-DCO-1.0-Signed-off-by: Zoltan Herczeg zherczeg.u-szeged@partner.samsung.com
This commit is contained in:
Zoltan Herczeg 2020-11-16 15:04:22 +01:00 committed by GitHub
parent 640a7d33b3
commit 1237bef0f0
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 31 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
jerry-core/parser/js/js-scanner-util.c
View File

@ -2674,7 +2674,8 @@ scanner_create_variables (parser_context_t *context_p, /**< context */
{
opcode = CBC_CREATE_VAR_EVAL;
if (context_p->global_status_flags & ECMA_PARSE_FUNCTION_CONTEXT)
if ((context_p->global_status_flags & ECMA_PARSE_FUNCTION_CONTEXT)
&& !(context_p->status_flags & PARSER_IS_STRICT))
{
opcode = PARSER_TO_EXT_OPCODE (CBC_EXT_CREATE_VAR_EVAL);
}

29
tests/jerry/es.next/regresssion-test-issue-4018.js Normal file
View File

@ -0,0 +1,29 @@
// Copyright JS Foundation and other contributors, http://js.foundation
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
[
'"\\ubad',
].forEach(function(result = JSON.parse (str, function (k, v) {
return v;
})) {
r = eval ('"use ' + 's' + 't' + 'r' + 'i' + 'c' + 't"; va' + 'r x = 1;');
});
// Better test
function f(result = function () {}) {
var x = 1;
eval ('"use strict"; var x = 2; assert(x === 2)');
assert(x === 1)
}
f()