archive-gh-me/jerryscript
1
0
Fork 0
mirror of https://github.com/jerryscript-project/jerryscript.git synced 2025-12-15 16:29:21 +00:00
Code Issues Projects Releases Wiki Activity

Fix ecma_op_array_object_set_length method

Browse Source 
So far a freed variable was tested during error flag inspection.
This patch fixes it and #1972 as well.

JerryScript-DCO-1.0-Signed-off-by: Robert Fancsik frobert@inf.u-szeged.hu
This commit is contained in:
Robert Fancsik 2017-08-29 16:52:46 +02:00 committed by yichoi
parent 733f0ceea0
commit 0ef2418e5e
2 changed files with 26 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
jerry-core/ecma/operations/ecma-array-object.c
View File

@ -162,7 +162,7 @@ ecma_op_array_object_set_length (ecma_object_t *object_p, /**< the array object
{
ecma_value_t compared_num_val = ecma_op_to_number (new_value);
if (ECMA_IS_VALUE_ERROR (completion))
if (ECMA_IS_VALUE_ERROR (compared_num_val))
{
return compared_num_val;
}

25
tests/jerry/regression-test-issue-1972.js Normal file
View File

@ -0,0 +1,25 @@
// Copyright JS Foundation and other contributors, http://js.foundation
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
try {
[].length = {
valueOf: function() {
return Array.prototype.push (1), Object.freeze (Array.prototype);
}
}
assert (false);
}
catch (e) {
assert (e instanceof TypeError);
}